Re: [PATCH net-next v8 8/9] net: mdio: realtek-rtl9300: Add support for RTL838x

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The allocated `priv` memory and its initialized mutex are leaked when `otto_emdio_init_polling()` fails during probe.
--

--- Patch [8]: [PATCH net-next v8 8/9] net: mdio: realtek-rtl9300: Add support for RTL838x ---
commit 19d0237c1026399704945da64c7e3b5e4a2158fe
Author: Markus Stockhausen <markus.stockhausen@gmx.de>

net: mdio: realtek-rtl9300: Add support for RTL838x

The MDIO driver has been prepared for multiple device support. Add all
required bits for the RTL838x (aka maple) series. This is straightforward
but some things are worth mentioning.

> diff --git a/drivers/net/mdio/mdio-realtek-rtl9300.c b/drivers/net/mdio/mdio-realtek-rtl9300.c
> index ef4fa8e8274f4..9f76698a84c55 100644
> --- a/drivers/net/mdio/mdio-realtek-rtl9300.c
> +++ b/drivers/net/mdio/mdio-realtek-rtl9300.c
[ ... ]
> @@ -880,6 +965,28 @@ static int otto_emdio_probe(struct platform_device *pdev)
>  	return err;
>  }

[Severity: Medium]
Does this code leak the allocated priv memory and its initialized mutex if
otto_emdio_init_polling() fails?

Looking at otto_emdio_probe():

	priv = kzalloc(sizeof(*priv), GFP_KERNEL);
	if (!priv)
		return -ENOMEM;

	kref_init(&priv->kref);
	mutex_init(&priv->lock);
	...
	err = otto_emdio_init_polling(priv);
	if (err)
		return err;

Should this goto err_out instead of returning directly to ensure kref_put() is
called and the resources are cleaned up?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260727191559.19617-1-markus.stockhausen@gmx.de?part=8