From: sashiko-bot@kernel.org
To: "Shawn Guo" <shengchao.guo@oss.qualcomm.com>
Cc: devicetree@vger.kernel.org, robh@kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH v8 4/6] dt-bindings: arm: qcom: Document Nord reference boards
Date: Wed, 29 Jul 2026 01:08:29 +0000 [thread overview]
Message-ID: <20260729010830.3F1991F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260729010022.875799-5-shengchao.guo@oss.qualcomm.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The schema omits the required specific SoC compatible strings (`qcom,sa8797p` and `qcom,iq10`) for the new Nord boards, restricting the valid compatible array to exactly two items.
--
--- Patch [4]: [PATCH v8 4/6] dt-bindings: arm: qcom: Document Nord reference boards ---
commit 460ffcc78443a859799a20a78b0fc8610e9fa849
Author: Shawn Guo <shengchao.guo@oss.qualcomm.com>
dt-bindings: arm: qcom: Document Nord reference boards
Nord is a new generation of SoC series from Qualcomm which includes
SA8797P (for Automotive) and Dragonwing IQ10 (for IOT/Robotics).
Document SA8797P Ride and IQ10 Robotics Reference Design (RRD) boards.
> diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
> --- a/Documentation/devicetree/bindings/arm/qcom.yaml
> +++ b/Documentation/devicetree/bindings/arm/qcom.yaml
[ ... ]
> @@ -401,6 +401,12 @@ properties:
> - xiaomi,sagit
> - const: qcom,msm8998
>
> + - items:
> + - enum:
> + - qcom,iq10-rrd
> + - qcom,sa8797p-ride
> + - const: qcom,nord
[Severity: Medium]
Does this restrict the compatible string array to exactly two items, omitting
the specific SoCs?
The commit message explicitly mentions SA8797P and IQ10, but the schema
only allows the board and the base series (qcom,nord). Standard Qualcomm
compatible chains usually include the specific SoC (e.g., qcom,sa8797p).
Will device trees that include a structurally correct 3-item compatible
chain fail dt_binding_check, forcing them to omit the specific SoC string
and potentially preventing future drivers from matching on SoC-specific quirks?
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260729010022.875799-1-shengchao.guo@oss.qualcomm.com?part=4
next prev parent reply other threads:[~2026-07-29 1:08 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-29 1:00 [PATCH v8 0/6] Add initial device trees for Nord platform Shawn Guo
2026-07-29 1:00 ` [PATCH v8 1/6] arm64: dts: qcom: Add device tree for Nord SoC series Shawn Guo
2026-07-29 1:14 ` sashiko-bot
2026-07-29 1:00 ` [PATCH v8 2/6] arm64: dts: qcom: Add device tree for Nord GearVM variant Shawn Guo
2026-07-29 1:00 ` [PATCH v8 3/6] arm64: dts: qcom: Add device tree for Nord Embedded variant Shawn Guo
2026-07-29 1:10 ` sashiko-bot
2026-07-29 1:00 ` [PATCH v8 4/6] dt-bindings: arm: qcom: Document Nord reference boards Shawn Guo
2026-07-29 1:08 ` sashiko-bot [this message]
2026-07-29 1:00 ` [PATCH v8 5/6] arm64: dts: qcom: Add device tree for Nord Ride board Shawn Guo
2026-07-29 1:00 ` [PATCH v8 6/6] arm64: dts: qcom: Add device tree for Nord RRD board Shawn Guo
2026-07-29 1:13 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260729010830.3F1991F000E9@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=shengchao.guo@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox