Re: [PATCH 1/2] dt-bindings: media: i2c: dongwoon,dw9714: Document DW9714A and V variant

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The YAML schema enforces a strict linear inheritance chain requiring the `dw9714v` compatible string to fall back to `dw9714a`, which contradicts the commit message implying they are parallel successors.
--

--- Patch [1]: [PATCH 1/2] dt-bindings: media: i2c: dongwoon,dw9714: Document DW9714A and V variant ---
commit 365235f208f468a1251293b975a2766eb66ab8bc
Author: David Heidelberg <david@ixit.cz>

dt-bindings: media: i2c: dongwoon,dw9714: Document DW9714A and V variant

This commit updates the device tree binding for the Dongwoon DW9714 to
document the DW9714A and DW9714V variants. It uses a oneOf structure to
allow the new successors as compatible strings.

> diff --git a/Documentation/devicetree/bindings/media/i2c/dongwoon,dw9714.yaml b/Documentation/devicetree/bindings/media/i2c/dongwoon,dw9714.yaml
> --- a/Documentation/devicetree/bindings/media/i2c/dongwoon,dw9714.yaml
> +++ b/Documentation/devicetree/bindings/media/i2c/dongwoon,dw9714.yaml
[ ... ]
> @@ -15,7 +15,15 @@ description:
>  
>  properties:
>    compatible:
> -    const: dongwoon,dw9714
> +    oneOf:
> +      - items:
> +          - const: dongwoon,dw9714v
> +          - const: dongwoon,dw9714a
> +          - const: dongwoon,dw9714

[Severity: Medium]
The commit message states "Both of these successors are backward compatible",
implying that the DW9714A and DW9714V variants are parallel successors to
the base DW9714.

However, this schema enforces a linear 3-item inheritance chain requiring
dongwoon,dw9714v to fall back to dongwoon,dw9714a before dongwoon,dw9714.

If a devicetree node defines a 2-item fallback for the V variant like
"dongwoon,dw9714v", "dongwoon,dw9714", it will fail dt_binding_check
validation.

Should dongwoon,dw9714v be allowed to fall back directly to dongwoon,dw9714
as a 2-item list if they are parallel successors?

> +      - items:
> +          - const: dongwoon,dw9714a
> +          - const: dongwoon,dw9714
> +      - const: dongwoon,dw9714

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260729-dw9714v-v1-0-3c479b3cf8c0@ixit.cz?part=1