From: Krzysztof Kozlowski <krzk@kernel.org>
To: Esteban Urrutia <esteuwu@proton.me>
Cc: Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Heikki Krogerus <heikki.krogerus@linux.intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org,
phone-devel@vger.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: soc: qcom: qcom,pmic-glink: Add compatible string for SM8475
Date: Thu, 30 Jul 2026 11:03:22 +0200 [thread overview]
Message-ID: <20260730-resourceful-scrupulous-goshawk-c9ea53@quoll> (raw)
In-Reply-To: <20260729-sm8475-pmic-glink-v1-1-c2e1967c04de@proton.me>
On Wed, Jul 29, 2026 at 03:48:24PM -0400, Esteban Urrutia wrote:
> Add compatible string for pmic-glink.
First, not true. You did not add compatible for pmic-glink.
Second, that's redundant. You just repeated subject and the diff
(although incorrectly). Explain why this is not compatible with existing
variants, writing bindings EXPLICITLY ask for that.
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-07-30 9:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-29 19:48 [PATCH 0/2] Support for pmic-glink in SM8475 Esteban Urrutia via B4 Relay
2026-07-29 19:48 ` [PATCH 1/2] dt-bindings: soc: qcom: qcom,pmic-glink: Add compatible string for SM8475 Esteban Urrutia via B4 Relay
2026-07-30 9:03 ` Krzysztof Kozlowski [this message]
2026-07-29 19:48 ` [PATCH 2/2] usb: typec: ucsi: ucsi_glink: " Esteban Urrutia via B4 Relay
2026-07-29 19:58 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260730-resourceful-scrupulous-goshawk-c9ea53@quoll \
--to=krzk@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=esteuwu@proton.me \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=phone-devel@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox