From: sashiko-bot@kernel.org
To: "Hrushiraj Gandhi" <hrushirajg23@gmail.com>
Cc: conor+dt@kernel.org, devicetree@vger.kernel.org, robh@kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: arm: rockchip: Add Vicharak Axon Lite board
Date: Thu, 30 Jul 2026 13:54:38 +0000 [thread overview]
Message-ID: <20260730135438.900901F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260730134815.434654-2-hrushirajg23@gmail.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The vendor prefix 'vicharak' is used in the compatible string 'vicharak,axon-lite' but is not registered in the vendor prefix registry.
--
--- Patch [1]: [PATCH 1/2] dt-bindings: arm: rockchip: Add Vicharak Axon Lite board ---
commit 6805625dcdf6088c2bf6394082251d13fbae2a6c
Author: Hrushiraj Gandhi <hrushirajg23@gmail.com>
dt-bindings: arm: rockchip: Add Vicharak Axon Lite board
Document the compatible string for the Vicharak Axon Lite, an RK3576-based
single-board computer.
> diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml b/Documentation/devicetree/bindings/arm/rockchip.yaml
> --- a/Documentation/devicetree/bindings/arm/rockchip.yaml
> +++ b/Documentation/devicetree/bindings/arm/rockchip.yaml
> @@ -1306,6 +1306,11 @@ properties:
> - const: turing,rk1
> - const: rockchip,rk3588
>
> + - description: Vicharak Axon Lite
> + items:
> + - const: vicharak,axon-lite
[Severity: Low]
Is the vendor prefix "vicharak" registered in the vendor prefix registry?
It appears this might cause dt_binding_check validation to fail with a
warning or error due to the undocumented vendor prefix. Does this patch
series include a corresponding update to vendor-prefixes.yaml that I might
have missed?
> + - const: rockchip,rk3576
> +
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260730134815.434654-1-hrushirajg23@gmail.com?part=1
next prev parent reply other threads:[~2026-07-30 13:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-30 13:48 [PATCH 0/2] Add support for Vicharak Axon Lite board Hrushiraj Gandhi
2026-07-30 13:48 ` [PATCH 1/2] dt-bindings: arm: rockchip: Add " Hrushiraj Gandhi
2026-07-30 13:54 ` sashiko-bot [this message]
2026-07-30 13:48 ` [PATCH 2/2] arm64: dts: " Hrushiraj Gandhi
2026-07-30 13:58 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260730135438.900901F000E9@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=hrushirajg23@gmail.com \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox