Re: [PATCH 2/2] arm64: dts: rockchip: Add Vicharak Axon Lite board

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Low] Explicitly defined UFS regulators are not linked to the UFS host controller node.
- [Low] The sdhci (eMMC) node specifies full-pwr-cycle-in-suspend but lacks regulator linkages.
--

--- Patch [2]: [PATCH 2/2] arm64: dts: rockchip: Add Vicharak Axon Lite board ---
commit 0d3ea17fe4a76d8ba79037c8dbb6e188fec6a23b
Author: Hrushiraj Gandhi <hrushirajg23@gmail.com>

arm64: dts: rockchip: Add Vicharak Axon Lite board
    
Add initial devicetree support for the Vicharak Axon Lite, an RK3576-based
single-board computer. Includes support for eMMC, UFS storage, and other
peripherals.

> diff --git a/arch/arm64/boot/dts/rockchip/rk3576-vicharak-axon-lite.dts b/arch/arm64/boot/dts/rockchip/rk3576-vicharak-axon-lite.dts
> new file mode 100644
> index 0000000000000..56b66e9f4fe14
> --- /dev/null
> +++ b/arch/arm64/boot/dts/rockchip/rk3576-vicharak-axon-lite.dts

[ ... ]

> +&sdhci {
> +	bus-width = <8>;
> +	full-pwr-cycle-in-suspend;

[Severity: Low]
Does this node need vmmc-supply and vqmmc-supply linkages to successfully
perform the requested power cycle?

The sdhci node specifies full-pwr-cycle-in-suspend to instruct the MMC core
to fully power cycle the eMMC card during system suspend and resume. Without
the supply linkages, the subsystem uses dummy regulators and cannot physically
toggle power to the card.

> +	max-frequency = <200000000>;
> +	mmc-hs400-1_8v;
> +	mmc-hs400-enhanced-strobe;

[ ... ]

> +&uart0 {
> +	pinctrl-names = "default";
> +	pinctrl-0 = <&uart0m0_xfer>;
> +	status = "okay";
> +};
> +
> +&ufshc {
> +	status = "okay";
> +};

[Severity: Low]
Should this node link to the explicit UFS regulators defined earlier in the
device tree?

The board defines regulators for UFS (vcc_1v2_ufs_vccq_s0,
vcc_1v8_ufs_vccq2_s0, and vcc_2v5_ufs_s0), but they are not linked to the
UFS host controller node via vcc-supply, vccq-supply, and vccq2-supply
bindings.

While the device still boots successfully because the defined regulators
are marked regulator-always-on and regulator-boot-on, omitting the linkages
obscures the actual power topology and prevents the driver from managing power
states dynamically.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260730134815.434654-1-hrushirajg23@gmail.com?part=2