Re: [PATCH v6 08/15] ASoC: qdsp6: q6afe-dai: add internal mi2s support

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [High] Missing DAPM routing entries for LPI MI2S ports in q6routing.c renders them unusable.
--

--- Patch [8]: [PATCH v6 08/15] ASoC: qdsp6: q6afe-dai: add internal mi2s support ---
commit e726403dddb3e85ced40616ddd6f3d6790dddb30
Author: Richard Acayan <mailingradian@gmail.com>

ASoC: qdsp6: q6afe-dai: add internal mi2s support

This commit adds support for internal MI2S ports on q6afe using the existing
LPI MI2S bindings. It introduces the necessary port preparation logic, DAPM
widgets, and DAPM routes for LPI_MI2S_RX_0 through LPI_MI2S_TX_6.

> diff --git a/sound/soc/qcom/qdsp6/q6afe-dai.c b/sound/soc/qcom/qdsp6/q6afe-dai.c
> index a0d21034a6264..920345609d2c8 100644
> --- a/sound/soc/qcom/qdsp6/q6afe-dai.c
> +++ b/sound/soc/qcom/qdsp6/q6afe-dai.c
[ ... ]
> @@ -665,6 +667,21 @@ static const struct snd_soc_dapm_route q6afe_dapm_routes[] = {
>  
>  	/* USB playback AFE port receives data for playback, hence use the RX port */
>  	{"USB Playback", NULL, "USB_RX"},
> +
> +	{"LPI RX0 MI2S Playback", NULL, "LPI_MI2S_RX_0"},
> +	{"LPI_MI2S_TX_0", NULL, "LPI TX0 MI2S Capture"},
> +	{"LPI RX1 MI2S Playback", NULL, "LPI_MI2S_RX_1"},
> +	{"LPI_MI2S_TX_1", NULL, "LPI TX1 MI2S Capture"},
> +	{"LPI RX2 MI2S Playback", NULL, "LPI_MI2S_RX_2"},
> +	{"LPI_MI2S_TX_2", NULL, "LPI TX2 MI2S Capture"},
> +	{"LPI RX3 MI2S Playback", NULL, "LPI_MI2S_RX_3"},
> +	{"LPI_MI2S_TX_3", NULL, "LPI TX3 MI2S Capture"},
> +	{"LPI RX4 MI2S Playback", NULL, "LPI_MI2S_RX_4"},
> +	{"LPI_MI2S_TX_4", NULL, "LPI TX4 MI2S Capture"},
> +	{"LPI RX5 MI2S Playback", NULL, "LPI_MI2S_RX_5"},
> +	{"LPI_MI2S_TX_5", NULL, "LPI TX5 MI2S Capture"},
> +	{"LPI RX6 MI2S Playback", NULL, "LPI_MI2S_RX_6"},
> +	{"LPI_MI2S_TX_6", NULL, "LPI TX6 MI2S Capture"},
>  };

[Severity: High]
Are DAPM routing entries for the new LPI MI2S ports also required in
sound/soc/qcom/qdsp6/q6routing.c?

Looking at how other ports are routed, it seems we might be missing the
audio mixers in msm_qdsp6_widgets (such as an "LPI_MI2S_RX_0 Audio Mixer")
and the Front-End to Back-End mapping in the intercon array.

Without these entries in q6routing.c, will the ASoC core be able to
construct a valid audio path? It appears these newly added Back-End DAIs
might remain completely disconnected from the Front-End MultiMedia streams,
causing attempts to play or capture audio through them to fail.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260730174353.108023-1-mailingradian@gmail.com?part=8