Re: [PATCH v6 06/15] ASoC: qdsp6: q6dsp-lpass-ports: add support for lpi mi2s ports 5-6

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [High] The newly added LPI MI2S DAIs lack corresponding backend AFE port mappings and configuration handlers, causing DAI probe and stream preparation to unconditionally fail on AFE-based systems like SDM660.
--

--- Patch [6]: [PATCH v6 06/15] ASoC: qdsp6: q6dsp-lpass-ports: add support for lpi mi2s ports 5-6 ---
commit d2dcc25c1d269d302ba0498e0de038f74d01d735
Author: Richard Acayan <mailingradian@gmail.com>

ASoC: qdsp6: q6dsp-lpass-ports: add support for lpi mi2s ports 5-6

This commit adds the extra LPI MI2S ports used for internal MI2S on SDM660.

Link: https://android.googlesource.com/kernel/msm-extra/+/530cffa4cc977a348753831b163eb9d3302b954a/asoc/msm-dai-q6-v2.c#4597

> diff --git a/sound/soc/qcom/qdsp6/q6dsp-lpass-ports.c b/sound/soc/qcom/qdsp6/q6dsp-lpass-ports.c
> index e5cd82f77b552..c3d8116ad5035 100644
> --- a/sound/soc/qcom/qdsp6/q6dsp-lpass-ports.c
> +++ b/sound/soc/qcom/qdsp6/q6dsp-lpass-ports.c
> @@ -553,11 +553,15 @@ static struct snd_soc_dai_driver q6dsp_audio_fe_dais[] = {
>  	Q6AFE_MI2S_RX_DAI("LPI RX2", LPI_MI2S_RX_2),
>  	Q6AFE_MI2S_RX_DAI("LPI RX3", LPI_MI2S_RX_3),
>  	Q6AFE_MI2S_RX_DAI("LPI RX4", LPI_MI2S_RX_4),
> +	Q6AFE_MI2S_RX_DAI("LPI RX5", LPI_MI2S_RX_5),
> +	Q6AFE_MI2S_RX_DAI("LPI RX6", LPI_MI2S_RX_6),
>  	Q6AFE_MI2S_TX_DAI("LPI TX0", LPI_MI2S_TX_0),
>  	Q6AFE_MI2S_TX_DAI("LPI TX1", LPI_MI2S_TX_1),
>  	Q6AFE_MI2S_TX_DAI("LPI TX2", LPI_MI2S_TX_2),
>  	Q6AFE_MI2S_TX_DAI("LPI TX3", LPI_MI2S_TX_3),
>  	Q6AFE_MI2S_TX_DAI("LPI TX4", LPI_MI2S_TX_4),
> +	Q6AFE_MI2S_TX_DAI("LPI TX5", LPI_MI2S_TX_5),
> +	Q6AFE_MI2S_TX_DAI("LPI TX6", LPI_MI2S_TX_6),

[Severity: High]
Will these new ports fail to probe and prepare because they are missing
backend AFE port mappings and configuration handlers?

When the machine driver binds to the LPI MI2S DAIs, q6afe_port_get_from_id()
looks up the port mapping in the static port_maps array in
sound/soc/qcom/qdsp6/q6afe.c.

Because the new LPI_MI2S ports are missing from the port_maps array, the
port_id used for the lookup will be 0 (uninitialized). This causes the
switch statement in q6afe_port_get_from_id() to fall through to the default
error case and return -EINVAL:

sound/soc/qcom/qdsp6/q6afe.c:q6afe_port_get_from_id() {
    ...
    switch (port_id) {
    ...
    default:
        dev_err(dev, "AFE port id not supported %d\n", port_id);
        return ERR_PTR(-EINVAL);
    }
}

Furthermore, q6afe_dai_prepare() and of_q6afe_parse_dai_data() in
sound/soc/qcom/qdsp6/q6afe-dai.c also lack switch cases for the new
ports, which guarantees they will fall back to their default error paths.

Should these ports also be added to the port_maps array and the relevant
switch statements in q6afe.c and q6afe-dai.c?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260730174353.108023-1-mailingradian@gmail.com?part=6