Re: [PATCH v2 10/11] dtc: dt-check-style: Add warning for redundant white-spaces

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Redundant whitespace checks evaluate raw text without stripping string literals and comments, causing spurious warnings on valid syntax.
--

--- Patch [10]: [PATCH v2 10/11] dtc: dt-check-style: Add warning for redundant white-spaces ---
commit 9dee972d11110f1e641562b1a539ae177f4a7331
Author: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
Subject: dtc: dt-check-style: Add warning for redundant white-spaces

This commit adds warnings to the dt-check-style script for redundant
whitespace around '=', before '{' and ';', or when using tabs for these.
It introduces both relaxed and strict modes to handle existing trees.

> diff --git a/scripts/dtc/dt-check-style b/scripts/dtc/dt-check-style
> index 56d8d0c217f20..6512cf5cfddec 100755
> --- a/scripts/dtc/dt-check-style
> +++ b/scripts/dtc/dt-check-style

[ ... ]

> @@ -348,6 +348,36 @@ def check_trailing_whitespace(ctx):
>              yield (dl.lineno, 'trailing whitespace')
>  
>  
> +def check_redundant_whitespace(ctx):
> +    """No whitespace between brackets or other code elements.
> +    See also check_value_whitespace() for more checks."""
> +    for dl in ctx.lines:
> +        if dl.linetype in (LineType.COMMENT, LineType.COMMENT_BODY,
> +                           LineType.COMMENT_END, LineType.COMMENT_START,
> +                           LineType.PREPROCESSOR):
> +            continue
> +        if re.search(r'(\s\s+|\t){', dl.raw):
> +            yield (dl.lineno, 'extra whitespace before {')
> +        if re.search(r':(\s\s+|\t)', dl.raw):
> +            yield (dl.lineno, 'extra whitespace after :')
> +        if re.search(r'\s+;', dl.raw):

[Severity: Medium]
Will these regex checks incorrectly flag valid whitespace within string
literals or inline comments?

Since dl.raw isn't stripped of strings or inline comments, a line parsed as
a PROPERTY with a string like:
    bootargs = "console=ttyS0 quiet  ; "
or an inline comment like:
    prop = <1>; /* foo  ; */
would trigger a spurious warning here.

Should this use a stripped version of the line instead of dl.raw?

> +            yield (dl.lineno, 'extra whitespace before ;')
> +
> +
> +def check_redundant_whitespace_strict(ctx):
> +    """No whitespace between brackets or other code elements.
> +    See also check_value_whitespace() for more checks."""
> +    for dl in ctx.lines:
> +        if dl.linetype in (LineType.COMMENT, LineType.COMMENT_BODY,
> +                           LineType.COMMENT_END, LineType.COMMENT_START,
> +                           LineType.PREPROCESSOR):
> +            continue
> +        if re.search(r'(\s\s+|\t)=', dl.raw):
> +            yield (dl.lineno, 'extra whitespace before =')
> +        if re.search(r'=(\s\s+|\t)', dl.raw):

[Severity: Medium]
Similarly, does checking dl.raw directly here cause false positives for
lines containing strings with extra spaces around '='?

For example, a valid property like:
    args = "a  =  b"
would match these strict regular expressions.

> +            yield (dl.lineno, 'extra whitespace after =')

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260802-n-dts-style-checker-continued-v2-0-6c5dbd1ccfe4@oss.qualcomm.com?part=10