Re: [PATCH RFC 1/3] dt-bindings: sound: Add NXP TFA98XX TFA2 amplifier binding

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The YAML schema fails to implement the compatible strings and IRQ properties promised in the commit message.
--

--- Patch [1]: [PATCH RFC 1/3] dt-bindings: sound: Add NXP TFA98XX TFA2 amplifier binding ---
commit fcdff8de986493484ef077c116e00cc54ac329f0
Author: David Heidelberg <david@ixit.cz>

dt-bindings: sound: Add NXP TFA98XX TFA2 amplifier binding

Adds a YAML devicetree binding schema for the NXP/Goodix TFA98XX TFA2
family of I2C-controlled smart speaker amplifiers with on-chip DSP.

> diff --git a/Documentation/devicetree/bindings/sound/nxp,tfa98xx.yaml b/Documentation/devicetree/bindings/sound/nxp,tfa98xx.yaml
> new file mode 100644
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/sound/nxp,tfa98xx.yaml
[ ... ]
> +properties:
> +  compatible:
> +    enum:
> +      - nxp,tfa9894
> +
> +  reg:
> +    maxItems: 1
> +
> +  reset-gpios:
> +    maxItems: 1

[Severity: Medium]
The commit message states this binding covers chip variants TFA9872
through TFA9912 and documents optional IRQ GPIO properties, but only
nxp,tfa9894 and reset-gpios are defined in the schema here.

Since unevaluatedProperties is set to false, won't device trees attempting
to use the other variants or IRQ functionality fail validation? Should the
additional compatible strings and IRQ properties be added to this list to
match the capabilities described in the commit message?

> +
> +  '#sound-dai-cells':
> +    const: 0

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260802-tfa98xx-upstream-v1-0-4dd55cdd658a@ixit.cz?part=1