Re: [PATCH RFC 2/3] ASoC: codecs: tfa98xx: add driver for TFA2 amplifiers

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The i2c_device_id array fails to use named initializers.
--

--- Patch [2]: [PATCH RFC 2/3] ASoC: codecs: tfa98xx: add driver for TFA2 amplifiers ---
commit 4120c0a8b537c48d7609971c712e99479ca0e3ec
Author: David Heidelberg <david@ixit.cz>

ASoC: codecs: tfa98xx: add driver for TFA2 amplifiers

This commit adds a driver for the NXP/Goodix TFA98xx (TFA2) smart speaker
amplifiers, initially supporting the TFA9894 found on the OnePlus 6T. 
The driver bypasses the built-in CoolFlux DSP and takes the amplifier input
straight from the TDM interface.

> diff --git a/sound/soc/codecs/tfa98xx.c b/sound/soc/codecs/tfa98xx.c
> new file mode 100644
> index 0000000000000..c84abb8db207a
> --- /dev/null
> +++ b/sound/soc/codecs/tfa98xx.c

[ ... ]

> +static const struct i2c_device_id tfa98xx_i2c_id[] = {
> +	{ "tfa9894", (kernel_ulong_t)&tfa9894_chip },
> +	{ }
> +};

[Severity: Low]
This isn't a bug, but should the tfa98xx_i2c_id array use named initializers
(such as .name = "tfa9894", .driver_data = ...) to align with the I2C
subsystem guidelines for initialized arrays of type struct i2c_device_id?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260802-tfa98xx-upstream-v1-0-4dd55cdd658a@ixit.cz?part=2