Re: [PATCH 10/28] arm64: dts: qcom: sm8550: Fix swapped USB QMP PHY vdda-phy/vdda-pll supplies

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:

Pre-existing issues:
- [High] The patch series fixes swapped `vdda-phy-supply` and `vdda-pll-supply` regulators for several boards (e.g., sm8550), but misses identical swaps in other QMP PHY users across the tree (e.g., sm8650, sm8750, x1e80100).
--

--- Patch [10]: [PATCH 10/28] arm64: dts: qcom: sm8550: Fix swapped USB QMP PHY vdda-phy/vdda-pll supplies ---
commit c8c05b6ce3c72eb6b9fb37b78a8e1a5e58bf14e9
Author: Manivannan Sadhasivam <manivannan.sadhasivam@oss.qualcomm.com>

arm64: dts: qcom: sm8550: Fix swapped USB QMP PHY vdda-phy/vdda-pll supplies

This commit corrects the swapped vdda-phy and vdda-pll supplies for USB QMP
PHYs on several SM8550 boards. By swapping the regulators back, it ensures
the PHY receives the expected 0.88V instead of 1.2V, and the PLL receives
1.2V instead of 0.88V.

> diff --git a/arch/arm64/boot/dts/qcom/sm8550-hdk.dts b/arch/arm64/boot/dts/qcom/sm8550-hdk.dts
> index ee13e6136a825..25ff5e39dd346 100644
> --- a/arch/arm64/boot/dts/qcom/sm8550-hdk.dts
> +++ b/arch/arm64/boot/dts/qcom/sm8550-hdk.dts
> @@ -1374,8 +1374,8 @@ &usb_1_hsphy {
>  };
>  
>  &usb_dp_qmpphy {
> -	vdda-phy-supply = <&vreg_l3e_1p2>;
> -	vdda-pll-supply = <&vreg_l3f_0p88>;
> +	vdda-phy-supply = <&vreg_l3f_0p88>;
> +	vdda-pll-supply = <&vreg_l3e_1p2>;
>  
>  	status = "okay";
>  };

[Severity: High]
This is a pre-existing issue, but does this same regulator swap bug affect
other boards across the tree?

Looking at other device trees, it appears the 1.2V and ~0.88V supplies
might still be swapped in several other QMP PHY configurations. For
example, in arch/arm64/boot/dts/qcom/sm8650-mtp.dts for usb_dp_qmpphy:

        vdda-phy-supply = <&vreg_l3i_1p2>;
        vdda-pll-supply = <&vreg_l3g_0p91>;

And similarly in arch/arm64/boot/dts/qcom/sm8750-mtp.dts:

        vdda-phy-supply = <&vreg_l3g_1p2>;
        vdda-pll-supply = <&vreg_l2d_0p88>;

Even the Snapdragon X Elite ecosystem seems to exhibit this pattern, such as
in arch/arm64/boot/dts/qcom/x1e80100-qcp.dts for usb_1_ss0_qmpphy:

        vdda-phy-supply = <&vreg_l2j_1p2>;
        vdda-pll-supply = <&vreg_l1j_0p8>;

Supplying 1.2V to the 0.88V PHY domain and 0.88V to the 1.2V PLL domain
might prevent the USB/DP PHY PLL from locking and risk hardware degradation
due to overvoltage on the PHY pins. Should these other boards be updated
with a similar fix?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260803-phy-supply-fix-v1-0-5880630cde3e@oss.qualcomm.com?part=10