Devicetree
 help / color / mirror / Atom feed
From: "Luca Weiss" <luca.weiss@fairphone.com>
To: <manivannan.sadhasivam@oss.qualcomm.com>,
	"Bjorn Andersson" <andersson@kernel.org>,
	"Konrad Dybcio" <konradybcio@kernel.org>,
	"Rob Herring" <robh@kernel.org>,
	"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
	"Conor Dooley" <conor+dt@kernel.org>
Cc: "Konrad Dybcio" <konrad.dybcio@oss.qualcomm.com>,
	<linux-arm-msm@vger.kernel.org>, <devicetree@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>,
	"Krzysztof Kozlowski" <krzk@kernel.org>,
	"Krzysztof Kozlowski" <krzysztof.kozlowski@oss.qualcomm.com>,
	"Manivannan Sadhasivam" <mani@kernel.org>
Subject: Re: [PATCH 14/28] arm64: dts: qcom: sm7225-fairphone-fp4: Fix swapped USB QMP PHY vdda-phy/vdda-pll supplies
Date: Tue, 04 Aug 2026 15:26:44 +0200	[thread overview]
Message-ID: <DKG6ZQDKN7L0.3A4YY34C315FN@fairphone.com> (raw)
In-Reply-To: <20260803-phy-supply-fix-v1-14-5880630cde3e@oss.qualcomm.com>

On Mon Aug 3, 2026 at 8:34 AM CEST, Manivannan Sadhasivam via B4 Relay wrote:
> From: Manivannan Sadhasivam <manivannan.sadhasivam@oss.qualcomm.com>
>
> The QMP PHY expects the vdda-phy supply to be around 0.88V and the
> vdda-pll supply to be 1.2V. But these two supplies are swapped for the
> USB QMP PHY on this board, feeding 1.2V to vdda-phy and 0.9V to
> vdda-pll.
>
> Fix it by swapping the two supplies back.
>
> Fixes: 4cbea668767d ("arm64: dts: qcom: sm7225: Add device tree for Fairphone 4")
> Reported-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
> Assisted-by: Claude:opus-4-8
> Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@oss.qualcomm.com>
> ---
>  arch/arm64/boot/dts/qcom/sm7225-fairphone-fp4.dts | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sm7225-fairphone-fp4.dts b/arch/arm64/boot/dts/qcom/sm7225-fairphone-fp4.dts
> index 23f950067a08..bea82cbc2c88 100644
> --- a/arch/arm64/boot/dts/qcom/sm7225-fairphone-fp4.dts
> +++ b/arch/arm64/boot/dts/qcom/sm7225-fairphone-fp4.dts
> @@ -1247,8 +1247,8 @@ &usb_1_hsphy {
>  };
>  
>  &usb_1_qmpphy {
> -	vdda-phy-supply = <&vreg_l22a>;
> -	vdda-pll-supply = <&vreg_l16a>;
> +	vdda-phy-supply = <&vreg_l16a>;
> +	vdda-pll-supply = <&vreg_l22a>;

Schematics confirm:
* VREG_L16A_0P88 <-> VDD_A_USBSSDP_0P9
* VREG_L22A_1P2 <-> VDD_A_USBSSDP_1P2

So this also matches.

Reviewed-by: Luca Weiss <luca.weiss@fairphone.com>

>  
>  	status = "okay";
>  };


  reply	other threads:[~2026-08-04 13:26 UTC|newest]

Thread overview: 48+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-03  6:33 [PATCH 00/28] arm64: dts: qcom: Fix swapped QMP PHY vdda-phy/vdda-pll supplies Manivannan Sadhasivam via B4 Relay
2026-08-03  6:33 ` [PATCH 01/28] dt-bindings: phy: qcom: Describe QMP USB and UFS PHY vdda-phy/vdda-pll voltages Manivannan Sadhasivam via B4 Relay
2026-08-04  8:36   ` Krzysztof Kozlowski
2026-08-03  6:34 ` [PATCH 02/28] arm64: dts: qcom: sc8280xp-blackrock: Fix swapped USB QMP PHY vdda-phy/vdda-pll supplies Manivannan Sadhasivam via B4 Relay
2026-08-03  6:44   ` sashiko-bot
2026-08-03  6:34 ` [PATCH 03/28] arm64: dts: qcom: sa8540p: " Manivannan Sadhasivam via B4 Relay
2026-08-03  6:46   ` sashiko-bot
2026-08-03  6:34 ` [PATCH 04/28] arm64: dts: qcom: sdm845: " Manivannan Sadhasivam via B4 Relay
2026-08-03  6:43   ` sashiko-bot
2026-08-03  6:34 ` [PATCH 05/28] arm64: dts: qcom: sdm850: " Manivannan Sadhasivam via B4 Relay
2026-08-03  6:44   ` sashiko-bot
2026-08-03  6:34 ` [PATCH 06/28] arm64: dts: qcom: sm8150: " Manivannan Sadhasivam via B4 Relay
2026-08-03  6:42   ` sashiko-bot
2026-08-03  6:34 ` [PATCH 07/28] arm64: dts: qcom: sm8250: " Manivannan Sadhasivam via B4 Relay
2026-08-03  6:34 ` [PATCH 08/28] arm64: dts: qcom: sm8350: " Manivannan Sadhasivam via B4 Relay
2026-08-03  6:51   ` sashiko-bot
2026-08-03  6:34 ` [PATCH 09/28] arm64: dts: qcom: sm8450: " Manivannan Sadhasivam via B4 Relay
2026-08-03  6:43   ` sashiko-bot
2026-08-03  6:34 ` [PATCH 10/28] arm64: dts: qcom: sm8550: " Manivannan Sadhasivam via B4 Relay
2026-08-03  6:41   ` sashiko-bot
2026-08-03  6:34 ` [PATCH 11/28] arm64: dts: qcom: qcs8550-aim300: " Manivannan Sadhasivam via B4 Relay
2026-08-03  6:34 ` [PATCH 12/28] arm64: dts: qcom: qcm6490: " Manivannan Sadhasivam via B4 Relay
2026-08-03  6:43   ` sashiko-bot
2026-08-04 13:24   ` Luca Weiss
2026-08-03  6:34 ` [PATCH 13/28] arm64: dts: qcom: qcs6490: " Manivannan Sadhasivam via B4 Relay
2026-08-03  6:46   ` sashiko-bot
2026-08-03  6:34 ` [PATCH 14/28] arm64: dts: qcom: sm7225-fairphone-fp4: " Manivannan Sadhasivam via B4 Relay
2026-08-04 13:26   ` Luca Weiss [this message]
2026-08-03  6:34 ` [PATCH 15/28] arm64: dts: qcom: sc7180: " Manivannan Sadhasivam via B4 Relay
2026-08-03  6:34 ` [PATCH 16/28] arm64: dts: qcom: sc7280: " Manivannan Sadhasivam via B4 Relay
2026-08-03  6:34 ` [PATCH 17/28] arm64: dts: qcom: sc8180x: " Manivannan Sadhasivam via B4 Relay
2026-08-03  6:34 ` [PATCH 18/28] arm64: dts: qcom: hamoa: " Manivannan Sadhasivam via B4 Relay
2026-08-03  6:45   ` sashiko-bot
2026-08-03  6:34 ` [PATCH 19/28] arm64: dts: qcom: purwa: " Manivannan Sadhasivam via B4 Relay
2026-08-03  6:34 ` [PATCH 20/28] arm64: dts: qcom: sm8650: " Manivannan Sadhasivam via B4 Relay
2026-08-03  6:34 ` [PATCH 21/28] arm64: dts: qcom: sm8750: " Manivannan Sadhasivam via B4 Relay
2026-08-03  6:34 ` [PATCH 22/28] arm64: dts: qcom: sar2130p: " Manivannan Sadhasivam via B4 Relay
2026-08-03  6:34 ` [PATCH 23/28] arm64: dts: qcom: kaanapali: " Manivannan Sadhasivam via B4 Relay
2026-08-03  6:34 ` [PATCH 24/28] arm64: dts: qcom: glymur: " Manivannan Sadhasivam via B4 Relay
2026-08-04 11:51   ` Abel Vesa
2026-08-03  6:34 ` [PATCH 25/28] arm64: dts: qcom: lemans: " Manivannan Sadhasivam via B4 Relay
2026-08-03  6:59   ` sashiko-bot
2026-08-03  6:34 ` [PATCH 26/28] arm64: dts: qcom: eliza-mtp: " Manivannan Sadhasivam via B4 Relay
2026-08-04 11:51   ` Abel Vesa
2026-08-03  6:34 ` [PATCH 27/28] arm64: dts: qcom: sa8155p-adp: Fix swapped USB and UFS " Manivannan Sadhasivam via B4 Relay
2026-08-03  6:34 ` [PATCH 28/28] arm64: dts: qcom: talos-evk: Fix swapped USB " Manivannan Sadhasivam via B4 Relay
2026-08-03  7:01   ` sashiko-bot
2026-08-05  3:33 ` [PATCH 00/28] arm64: dts: qcom: Fix swapped " Bjorn Andersson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DKG6ZQDKN7L0.3A4YY34C315FN@fairphone.com \
    --to=luca.weiss@fairphone.com \
    --cc=andersson@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=konrad.dybcio@oss.qualcomm.com \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=krzk@kernel.org \
    --cc=krzysztof.kozlowski@oss.qualcomm.com \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mani@kernel.org \
    --cc=manivannan.sadhasivam@oss.qualcomm.com \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox