Re: [PATCH v3 05/11] dtc: dt-check-style: Drop stray backslash before quote for continuation-alignment

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Incomplete fix introduces inconsistency: The rule description for 'continuation-alignment' in the RULES array was not updated to match the new warning message.
--

--- Patch [5]: [PATCH v3 05/11] dtc: dt-check-style: Drop stray backslash before quote for continuation-alignment ---
commit cc9a0068ab7c4a58265d453026c1b235168a19bd
Author: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>

dtc: dt-check-style: Drop stray backslash before quote for continuation-alignment

This commit updates the continuation-alignment rule warning to drop the stray
backslash and quotes around the character matching rules. It removes the
quotes around '<' and the escaped quote inside the parenthesis.

> diff --git a/scripts/dtc/dt-check-style b/scripts/dtc/dt-check-style
> index f9e5762862a51..bdf36ba9e2744 100755
> --- a/scripts/dtc/dt-check-style
> +++ b/scripts/dtc/dt-check-style
> @@ -950,7 +950,7 @@ def check_continuation_alignment(ctx):
>              if _display_col(cont.indent_str) != target_col:
>                  yield (cont.lineno,
>                         'continuation should align to column %d '
> -                       '(under "<" or \\")' % (target_col + 1))
> +                       '(under < or ")' % (target_col + 1))

[Severity: Low]
Does the RULES array description need to be updated to match this new text?

Looking further down in scripts/dtc/dt-check-style in the RULES array, the
rule description still has the old escaping and quotes:

    Rule('continuation-alignment', 'strict',
         'multi-line property continuations align under "<" or "\\""',
         check_continuation_alignment),

This will cause dt-check-style --list-rules to display the old style text
while the actual warning output uses the new style.

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260803-n-dts-style-checker-continued-v3-0-6c9776928cea@oss.qualcomm.com?part=5