Re: [PATCH v3 09/11] dtc: dt-check-style: Add test for trailing white-space in DTS

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The test file `bad/dts-trailing-ws.dts` is intended to trigger a trailing whitespace warning, but it does not actually contain any trailing whitespace. As a result, the style checker will not emit the expected warning, and the unit test will fail.
--

--- Patch [9]: [PATCH v3 09/11] dtc: dt-check-style: Add test for trailing white-space in DTS ---
commit a9f7c5c65b57ce006736994c5d872356aea7725f
Author: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>

dtc: dt-check-style: Add test for trailing white-space in DTS

Add unit tests for expected warnings for trailing white-spaces in DTS
(there is only one for YAML files).

> diff --git a/scripts/dtc/dt-style-selftest/bad/dts-trailing-ws.dts b/scripts/dtc/dt-style-selftest/bad/dts-trailing-ws.dts
> new file mode 100644
> index 0000000000000..ade160a443411
> --- /dev/null
> +++ b/scripts/dtc/dt-style-selftest/bad/dts-trailing-ws.dts
> @@ -0,0 +1,8 @@
> +// SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> +/dts-v1/;
> +
> +/ {
> +	compatible = "example,test-board";

[Severity: Medium]
Since this test file is intended to trigger a trailing whitespace warning on
this line, should it contain actual trailing whitespace? It appears to end 
exactly with a semicolon, which will cause the unit test to fail because
the style checker won't emit the expected warning.

Could the required whitespace have been inadvertently stripped by an editor or
commit hook?

> +	#address-cells = <1>;
> +	#size-cells = <1>;
> +};

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260803-n-dts-style-checker-continued-v3-0-6c9776928cea@oss.qualcomm.com?part=9