* [PATCH] dt-bindings: thermal: ti,omap-bandgap: Convert to DT schema
@ 2026-07-30 19:12 Bhargav Joshi
2026-08-03 22:22 ` Rob Herring
0 siblings, 1 reply; 2+ messages in thread
From: Bhargav Joshi @ 2026-07-30 19:12 UTC (permalink / raw)
To: Rafael J. Wysocki, Daniel Lezcano, Zhang Rui, Lukasz Luba,
Rob Herring, Krzysztof Kozlowski, Conor Dooley, Eduardo Valentin
Cc: linux-pm, devicetree, linux-kernel, goledhruva, m-chawdhry,
daniel.baluta, simona.toaca, j.bhargav.u
Convert Texas Instruments OMAP SCM bandgap from legacy text to DT schema
Add "ti,dra752-bandgap" to compatible which was missing in text binding
but used and matched by same driver.
Document the "#thermal-sensor-cells" property, which was missing from
the original text binding but is required in practice by all in-tree
users via the common thermal-sensor.yaml binding.
Signed-off-by: Bhargav Joshi <j.bhargav.u@gmail.com>
---
.../bindings/thermal/ti,omap-bandgap.yaml | 227 +++++++++++++++++++++
.../devicetree/bindings/thermal/ti_soc_thermal.txt | 88 --------
2 files changed, 227 insertions(+), 88 deletions(-)
diff --git a/Documentation/devicetree/bindings/thermal/ti,omap-bandgap.yaml b/Documentation/devicetree/bindings/thermal/ti,omap-bandgap.yaml
new file mode 100644
index 000000000000..5afd10a84f70
--- /dev/null
+++ b/Documentation/devicetree/bindings/thermal/ti,omap-bandgap.yaml
@@ -0,0 +1,227 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/thermal/ti,omap-bandgap.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Texas Instruments OMAP SCM bandgap
+
+maintainers:
+ - Eduardo Valentin <edubezval@gmail.com>
+
+description:
+ In the System Control Module, OMAP supplies a voltage reference and a
+ temperature sensor feature that are gathered in the band gap voltage and
+ temperature sensor (VBGAPTS) module. The band gap provides current and
+ voltage reference for its internal circuits and other analog IP blocks. The
+ analog-to-digital converter (ADC) produces an output value that is
+ proportional to the silicon temperature.
+
+properties:
+ compatible:
+ enum:
+ - ti,omap34xx-bandgap
+ - ti,omap36xx-bandgap
+ - ti,omap4430-bandgap
+ - ti,omap4460-bandgap
+ - ti,omap4470-bandgap
+ - ti,omap5430-bandgap
+ - ti,dra752-bandgap
+
+ reg:
+ minItems: 1
+ maxItems: 6
+
+ interrupts:
+ maxItems: 1
+
+ gpios:
+ maxItems: 1
+ description:
+ used to inform which GPIO line the tshut signal is routed to. The
+ informed GPIO will be treated as an IRQ;
+
+ "#thermal-sensor-cells":
+ enum: [0, 1]
+
+required:
+ - compatible
+ - reg
+
+allOf:
+ - $ref: thermal-sensor.yaml#
+
+ - if:
+ properties:
+ compatible:
+ contains:
+ enum:
+ - ti,omap34xx-bandgap
+ - ti,omap36xx-bandgap
+
+ then:
+ properties:
+ reg:
+ minItems: 1
+ maxItems: 1
+
+ interrupts: false
+
+ gpios: false
+
+ "#thermal-sensor-cells":
+ const: 0
+
+ - if:
+ properties:
+ compatible:
+ contains:
+ const: ti,omap4430-bandgap
+
+ then:
+ properties:
+ reg:
+ minItems: 2
+ maxItems: 2
+
+ interrupts: false
+
+ "#thermal-sensor-cells":
+ const: 0
+
+ required:
+ - gpios
+
+ - if:
+ properties:
+ compatible:
+ contains:
+ enum:
+ - ti,omap4460-bandgap
+ - ti,omap4470-bandgap
+
+ then:
+ properties:
+ reg:
+ minItems: 3
+ maxItems: 3
+
+ interrupts:
+ maxItems: 1
+
+ "#thermal-sensor-cells":
+ const: 0
+
+ required:
+ - interrupts
+ - gpios
+
+ - if:
+ properties:
+ compatible:
+ contains:
+ const: ti,omap5430-bandgap
+
+ then:
+ properties:
+ reg:
+ minItems: 4
+ maxItems: 4
+
+ interrupts:
+ maxItems: 1
+
+ gpios: false
+
+ "#thermal-sensor-cells":
+ const: 1
+
+ required:
+ - interrupts
+
+ - if:
+ properties:
+ compatible:
+ contains:
+ const: ti,dra752-bandgap
+
+ then:
+ properties:
+ reg:
+ minItems: 6
+ maxItems: 6
+
+ interrupts:
+ maxItems: 1
+
+ gpios: false
+
+ "#thermal-sensor-cells":
+ const: 1
+
+ required:
+ - interrupts
+
+unevaluatedProperties: false
+
+examples:
+ - |
+ bandgap@48002524 {
+ compatible = "ti,omap34xx-bandgap";
+ reg = <0x48002524 0x4>;
+ #thermal-sensor-cells = <0>;
+ };
+
+ - |
+ bandgap@48002524 {
+ compatible = "ti,omap36xx-bandgap";
+ reg = <0x48002524 0x4>;
+ #thermal-sensor-cells = <0>;
+ };
+
+ - |
+ #include <dt-bindings/gpio/gpio.h>
+
+ bandgap@4a002260 {
+ compatible = "ti,omap4430-bandgap";
+ reg = <0x4a002260 0x4>, <0x4a00232c 0x4>;
+ gpios = <&gpio3 22 GPIO_ACTIVE_HIGH>; /* tshut */
+ #thermal-sensor-cells = <0>;
+ };
+
+ - |
+ #include <dt-bindings/gpio/gpio.h>
+ #include <dt-bindings/interrupt-controller/irq.h>
+
+ bandgap@4a002260 {
+ compatible = "ti,omap4460-bandgap";
+ reg = <0x4a002260 0x4>, <0x4a00232c 0x4>, <0x4a002378 0x18>;
+ interrupts = <0 126 IRQ_TYPE_LEVEL_HIGH>; /* talert */
+ gpios = <&gpio3 22 GPIO_ACTIVE_HIGH>; /* tshut */
+ #thermal-sensor-cells = <0>;
+ };
+
+ - |
+ #include <dt-bindings/interrupt-controller/arm-gic.h>
+ #include <dt-bindings/interrupt-controller/irq.h>
+
+ bandgap@4a0021e0 {
+ compatible = "ti,omap5430-bandgap";
+ reg = <0x4a0021e0 0xc>, <0x4a00232c 0xc>,
+ <0x4a002380 0x2c>, <0x4a0023c0 0x3c>;
+ interrupts = <GIC_SPI 126 IRQ_TYPE_LEVEL_HIGH>; /* talert */
+ #thermal-sensor-cells = <1>;
+ };
+
+ - |
+ #include <dt-bindings/interrupt-controller/arm-gic.h>
+ #include <dt-bindings/interrupt-controller/irq.h>
+
+ bandgap@4a0021e0 {
+ compatible = "ti,dra752-bandgap";
+ reg = <0x4a0021e0 0xc>, <0x4a00232c 0xc>,
+ <0x4a002380 0x2c>, <0x4a0023c0 0x3c>,
+ <0x4a002564 0x8>, <0x4a002574 0x50>;
+ interrupts = <GIC_SPI 121 IRQ_TYPE_LEVEL_HIGH>; /* talert */
+ #thermal-sensor-cells = <1>;
+ };
diff --git a/Documentation/devicetree/bindings/thermal/ti_soc_thermal.txt b/Documentation/devicetree/bindings/thermal/ti_soc_thermal.txt
deleted file mode 100644
index 6299dd8de339..000000000000
--- a/Documentation/devicetree/bindings/thermal/ti_soc_thermal.txt
+++ /dev/null
@@ -1,88 +0,0 @@
-* Texas Instrument OMAP SCM bandgap bindings
-
-In the System Control Module, OMAP supplies a voltage reference
-and a temperature sensor feature that are gathered in the band
-gap voltage and temperature sensor (VBGAPTS) module. The band
-gap provides current and voltage reference for its internal
-circuits and other analog IP blocks. The analog-to-digital
-converter (ADC) produces an output value that is proportional
-to the silicon temperature.
-
-Required properties:
-- compatible : Should be:
- - "ti,omap34xx-bandgap" : for OMAP34xx bandgap
- - "ti,omap36xx-bandgap" : for OMAP36xx bandgap
- - "ti,omap4430-bandgap" : for OMAP4430 bandgap
- - "ti,omap4460-bandgap" : for OMAP4460 bandgap
- - "ti,omap4470-bandgap" : for OMAP4470 bandgap
- - "ti,omap5430-bandgap" : for OMAP5430 bandgap
-- interrupts : this entry should indicate which interrupt line
-the talert signal is routed to;
-Specific:
-- gpios : this entry should be used to inform which GPIO
-line the tshut signal is routed to. The informed GPIO will
-be treated as an IRQ;
-- regs : this entry must also be specified and it is specific
-to each bandgap version, because the mapping may change from
-soc to soc, apart of depending on available features.
-
-Example:
-OMAP34xx:
-bandgap {
- reg = <0x48002524 0x4>;
- compatible = "ti,omap34xx-bandgap";
-};
-
-OMAP36xx:
-bandgap {
- reg = <0x48002524 0x4>;
- compatible = "ti,omap36xx-bandgap";
-};
-
-OMAP4430:
-bandgap {
- reg = <0x4a002260 0x4 0x4a00232C 0x4>;
- compatible = "ti,omap4430-bandgap";
-};
-
-OMAP4460:
-bandgap {
- reg = <0x4a002260 0x4
- 0x4a00232C 0x4
- 0x4a002378 0x18>;
- compatible = "ti,omap4460-bandgap";
- interrupts = <0 126 4>; /* talert */
- gpios = <&gpio3 22 0>; /* tshut */
-};
-
-OMAP4470:
-bandgap {
- reg = <0x4a002260 0x4
- 0x4a00232C 0x4
- 0x4a002378 0x18>;
- compatible = "ti,omap4470-bandgap";
- interrupts = <0 126 4>; /* talert */
- gpios = <&gpio3 22 0>; /* tshut */
-};
-
-OMAP5430:
-bandgap {
- reg = <0x4a0021e0 0xc
- 0x4a00232c 0xc
- 0x4a002380 0x2c
- 0x4a0023C0 0x3c>;
- compatible = "ti,omap5430-bandgap";
- interrupts = <0 126 4>; /* talert */
-};
-
-DRA752:
-bandgap {
- reg = <0x4a0021e0 0xc
- 0x4a00232c 0xc
- 0x4a002380 0x2c
- 0x4a0023C0 0x3c
- 0x4a002564 0x8
- 0x4a002574 0x50>;
- compatible = "ti,dra752-bandgap";
- interrupts = <0 126 4>; /* talert */
-};
---
base-commit: fc02acf6ac0ccde0c805c2daa9148683cdd01ba8
change-id: 20260730-ti-bandgap-f7b3c67af6a6
Best regards,
--
Bhargav
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] dt-bindings: thermal: ti,omap-bandgap: Convert to DT schema
2026-07-30 19:12 [PATCH] dt-bindings: thermal: ti,omap-bandgap: Convert to DT schema Bhargav Joshi
@ 2026-08-03 22:22 ` Rob Herring
0 siblings, 0 replies; 2+ messages in thread
From: Rob Herring @ 2026-08-03 22:22 UTC (permalink / raw)
To: Bhargav Joshi
Cc: Rafael J. Wysocki, Daniel Lezcano, Zhang Rui, Lukasz Luba,
Krzysztof Kozlowski, Conor Dooley, Eduardo Valentin, linux-pm,
devicetree, linux-kernel, goledhruva, m-chawdhry, daniel.baluta,
simona.toaca
On Fri, Jul 31, 2026 at 12:42:38AM +0530, Bhargav Joshi wrote:
> Convert Texas Instruments OMAP SCM bandgap from legacy text to DT schema
>
> Add "ti,dra752-bandgap" to compatible which was missing in text binding
> but used and matched by same driver.
>
> Document the "#thermal-sensor-cells" property, which was missing from
> the original text binding but is required in practice by all in-tree
> users via the common thermal-sensor.yaml binding.
>
> Signed-off-by: Bhargav Joshi <j.bhargav.u@gmail.com>
> ---
> .../bindings/thermal/ti,omap-bandgap.yaml | 227 +++++++++++++++++++++
> .../devicetree/bindings/thermal/ti_soc_thermal.txt | 88 --------
> 2 files changed, 227 insertions(+), 88 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/thermal/ti,omap-bandgap.yaml b/Documentation/devicetree/bindings/thermal/ti,omap-bandgap.yaml
> new file mode 100644
> index 000000000000..5afd10a84f70
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/thermal/ti,omap-bandgap.yaml
> @@ -0,0 +1,227 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/thermal/ti,omap-bandgap.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Texas Instruments OMAP SCM bandgap
> +
> +maintainers:
> + - Eduardo Valentin <edubezval@gmail.com>
> +
> +description:
> + In the System Control Module, OMAP supplies a voltage reference and a
> + temperature sensor feature that are gathered in the band gap voltage and
> + temperature sensor (VBGAPTS) module. The band gap provides current and
> + voltage reference for its internal circuits and other analog IP blocks. The
> + analog-to-digital converter (ADC) produces an output value that is
> + proportional to the silicon temperature.
> +
> +properties:
> + compatible:
> + enum:
> + - ti,omap34xx-bandgap
> + - ti,omap36xx-bandgap
> + - ti,omap4430-bandgap
> + - ti,omap4460-bandgap
> + - ti,omap4470-bandgap
> + - ti,omap5430-bandgap
> + - ti,dra752-bandgap
> +
> + reg:
> + minItems: 1
> + maxItems: 6
> +
> + interrupts:
> + maxItems: 1
> +
> + gpios:
> + maxItems: 1
> + description:
> + used to inform which GPIO line the tshut signal is routed to. The
> + informed GPIO will be treated as an IRQ;
> +
> + "#thermal-sensor-cells":
> + enum: [0, 1]
> +
> +required:
> + - compatible
> + - reg
> +
> +allOf:
> + - $ref: thermal-sensor.yaml#
> +
> + - if:
> + properties:
> + compatible:
> + contains:
> + enum:
> + - ti,omap34xx-bandgap
> + - ti,omap36xx-bandgap
> +
> + then:
> + properties:
> + reg:
> + minItems: 1
> + maxItems: 1
> +
> + interrupts: false
> +
> + gpios: false
> +
> + "#thermal-sensor-cells":
> + const: 0
> +
> + - if:
> + properties:
> + compatible:
> + contains:
> + const: ti,omap4430-bandgap
> +
> + then:
> + properties:
> + reg:
> + minItems: 2
> + maxItems: 2
> +
> + interrupts: false
> +
> + "#thermal-sensor-cells":
> + const: 0
> +
> + required:
> + - gpios
> +
> + - if:
> + properties:
> + compatible:
> + contains:
> + enum:
> + - ti,omap4460-bandgap
> + - ti,omap4470-bandgap
> +
> + then:
> + properties:
> + reg:
> + minItems: 3
> + maxItems: 3
> +
> + interrupts:
> + maxItems: 1
Drop. 1 is already the max.
> +
> + "#thermal-sensor-cells":
> + const: 0
> +
> + required:
> + - interrupts
> + - gpios
> +
> + - if:
> + properties:
> + compatible:
> + contains:
> + const: ti,omap5430-bandgap
> +
> + then:
> + properties:
> + reg:
> + minItems: 4
> + maxItems: 4
> +
> + interrupts:
> + maxItems: 1
Drop. 1 is already the max.
> +
> + gpios: false
> +
> + "#thermal-sensor-cells":
> + const: 1
> +
> + required:
> + - interrupts
> +
> + - if:
> + properties:
> + compatible:
> + contains:
> + const: ti,dra752-bandgap
> +
> + then:
> + properties:
> + reg:
> + minItems: 6
> + maxItems: 6
> +
> + interrupts:
> + maxItems: 1
Drop. 1 is already the max.
> +
> + gpios: false
> +
> + "#thermal-sensor-cells":
> + const: 1
> +
> + required:
> + - interrupts
> +
> +unevaluatedProperties: false
> +
> +examples:
> + - |
> + bandgap@48002524 {
> + compatible = "ti,omap34xx-bandgap";
> + reg = <0x48002524 0x4>;
> + #thermal-sensor-cells = <0>;
> + };
> +
> + - |
> + bandgap@48002524 {
> + compatible = "ti,omap36xx-bandgap";
> + reg = <0x48002524 0x4>;
> + #thermal-sensor-cells = <0>;
> + };
> +
> + - |
> + #include <dt-bindings/gpio/gpio.h>
> +
> + bandgap@4a002260 {
> + compatible = "ti,omap4430-bandgap";
> + reg = <0x4a002260 0x4>, <0x4a00232c 0x4>;
> + gpios = <&gpio3 22 GPIO_ACTIVE_HIGH>; /* tshut */
> + #thermal-sensor-cells = <0>;
> + };
> +
> + - |
> + #include <dt-bindings/gpio/gpio.h>
> + #include <dt-bindings/interrupt-controller/irq.h>
> +
> + bandgap@4a002260 {
> + compatible = "ti,omap4460-bandgap";
> + reg = <0x4a002260 0x4>, <0x4a00232c 0x4>, <0x4a002378 0x18>;
> + interrupts = <0 126 IRQ_TYPE_LEVEL_HIGH>; /* talert */
> + gpios = <&gpio3 22 GPIO_ACTIVE_HIGH>; /* tshut */
> + #thermal-sensor-cells = <0>;
> + };
> +
> + - |
> + #include <dt-bindings/interrupt-controller/arm-gic.h>
> + #include <dt-bindings/interrupt-controller/irq.h>
> +
> + bandgap@4a0021e0 {
> + compatible = "ti,omap5430-bandgap";
> + reg = <0x4a0021e0 0xc>, <0x4a00232c 0xc>,
> + <0x4a002380 0x2c>, <0x4a0023c0 0x3c>;
> + interrupts = <GIC_SPI 126 IRQ_TYPE_LEVEL_HIGH>; /* talert */
> + #thermal-sensor-cells = <1>;
> + };
> +
> + - |
> + #include <dt-bindings/interrupt-controller/arm-gic.h>
> + #include <dt-bindings/interrupt-controller/irq.h>
> +
> + bandgap@4a0021e0 {
> + compatible = "ti,dra752-bandgap";
> + reg = <0x4a0021e0 0xc>, <0x4a00232c 0xc>,
> + <0x4a002380 0x2c>, <0x4a0023c0 0x3c>,
> + <0x4a002564 0x8>, <0x4a002574 0x50>;
> + interrupts = <GIC_SPI 121 IRQ_TYPE_LEVEL_HIGH>; /* talert */
> + #thermal-sensor-cells = <1>;
> + };
1 or 2 examples is enough. Perhaps the 1st and last to have the simplest
and most complex.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-08-03 22:22 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-07-30 19:12 [PATCH] dt-bindings: thermal: ti,omap-bandgap: Convert to DT schema Bhargav Joshi
2026-08-03 22:22 ` Rob Herring
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox