Re: [PATCH v2 09/10] arm64: ambarella: add ARCH_AMBARELLA and CV75 EVK DT

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] ARCH_AMBARELLA selects non-existent 32-bit ARM Kconfig symbols (ARM_PSCI and HAVE_ARM_ARCH_TIMER) on an arm64 build.
--

--- Patch [9]: [PATCH v2 09/10] arm64: ambarella: add ARCH_AMBARELLA and CV75 EVK DT ---
commit 30d61a45a9c8eee14cc764b1f10b92bd0992454f
Author: Long Zhao <longzhao@ambarella.com>

arm64: ambarella: add ARCH_AMBARELLA and CV75 EVK DT

Enable the Ambarella ARMv8 platform Kconfig, add the CV75 SoC and
EVK device trees, and select the Ambarella UART in the arm64
defconfig for console bring-up.

> diff --git a/arch/arm64/Kconfig.platforms b/arch/arm64/Kconfig.platforms
> index d2acfac730037..166430ddb3c93 100644
> --- a/arch/arm64/Kconfig.platforms
> +++ b/arch/arm64/Kconfig.platforms
> @@ -26,6 +26,15 @@ config ARCH_SUNXI
>  	help
>  	  This enables support for Allwinner sunxi based SoCs like the A64.
>  
> +config ARCH_AMBARELLA
> +	bool "Ambarella SoC family"
> +	select ARM_PSCI
> +	select HAVE_ARM_ARCH_TIMER

[Severity: Low]
Are these Kconfig selections intended?

The ARM_PSCI and HAVE_ARM_ARCH_TIMER symbols appear to be defined only in the
32-bit arch/arm/Kconfig tree and do not exist in the arm64 Kconfig. Because
they do not exist here, selecting them has no effect.

The 64-bit equivalents (ARM_PSCI_FW and ARM_ARCH_TIMER) are already
unconditionally selected by the top-level config ARM64.

> +	select PINCTRL
> +	select PINCTRL_AMB
> +	help
> +	  This enables support for the ARM64 based Ambarella SoCs like CV75.
> +
>  config ARCH_ALPINE

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260806-longzhao-upstream-cv75-v2-v2-0-6b09707c5fe9@ambarella.com?part=9