Re: [PATCH v3 01/19] dt-bindings: crypto: add Rambus CryptoManager Hub

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The `clock-names` schema uses an `items` list that strictly enforces positional sequence, preventing the valid use of the `rt` clock when the optional `core-div2` clock is omitted.
--

--- Patch [1]: [PATCH v3 01/19] dt-bindings: crypto: add Rambus CryptoManager Hub ---
commit 39b84af1941e37156bac8fca899b75a6fcb16e0b
Author: Alex Ousherovitch <aousherovitch@rambus.com>

dt-bindings: crypto: add Rambus CryptoManager Hub

This commit adds the device tree binding schema for the Rambus
CryptoManager Hub (CMH) hardware crypto accelerator. It defines the
SoC-level node properties and child nodes for hardware mailboxes.

> diff --git a/Documentation/devicetree/bindings/crypto/rambus,cmh.yaml b/Documentation/devicetree/bindings/crypto/rambus,cmh.yaml
> new file mode 100644
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/crypto/rambus,cmh.yaml
[ ... ]
> +  clocks:
> +    minItems: 1
> +    maxItems: 3
> +    description:
> +      Functional clocks driving the CryptoManager Hub.  The block gates its
> +      clocks internally (integrated clock-gating cell); the host does not
> +      gate them, so these describe the input pins only.  The names, in
> +      order, are "core" (the main functional clock), "core-div2" (a
> +      half-rate clock present only on configurations with
> +      side-channel-protected cores) and "rt" (the real-time tick clock
> +      for the internal timer).  Absent on integrations where a separate
> +      management/power controller owns the clocks and Linux has no clock
> +      handle.
> +
> +  clock-names:
> +    minItems: 1
> +    items:
> +      - const: core
> +      - const: core-div2
> +      - const: rt

[Severity: Medium]
Will this strict positional constraint cause valid configurations to fail
schema validation?

Since the description for the clocks property mentions that "core-div2" is 
present only on configurations with side-channel-protected cores, it appears
it can be omitted. 

If a device tree node omits the intermediate clock and specifies 
clock-names = "core", "rt", the second item in the array will be validated 
against the const: core-div2 constraint and fail.

Should oneOf sequence definitions or an enum-based array be used here to 
allow omitting intermediate optional clocks?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260806195519.2703224-1-skrishnamoorthy@rambus.com?part=1