Re: [PATCH v4 1/3] dt-bindings: platform: introduce EC for Dell XPS 13 9345

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The device tree binding example includes a non-existent header `<arm64/qcom/qcom-adc5-gen3.h>` and uses invalid macro syntax `ADC5_GEN3_AMUX3_GPIO_100K_PU(1)`.
--

--- Patch [1]: [PATCH v4 1/3] dt-bindings: platform: introduce EC for Dell XPS 13 9345 ---
commit 7f91f574545d4b995c0bfefa74700011122fb8e1
Author: Aleksandrs Vinarskis <alex@vinarskis.com>

dt-bindings: platform: introduce EC for Dell XPS 13 9345

Add bindings for Embedded Controller (EC) in Dell XPS 13 9345 (platform
codename 'tributo'). It may be partially or fully compatible with EC
found in Snapdragon-based Dell Latitude, Inspiron ('thena').

> diff --git a/Documentation/devicetree/bindings/embedded-controller/dell,xps13-9345-ec.yaml b/Documentation/devicetree/bindings/embedded-controller/dell,xps13-9345-ec.yaml
> new file mode 100644
> index 0000000000000..3485117b505cc
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/embedded-controller/dell,xps13-9345-ec.yaml

[ ... ]

> +examples:
> +  - |
> +    #include <dt-bindings/interrupt-controller/irq.h>
> +    #include <arm64/qcom/qcom-adc5-gen3.h>
> +    i2c {
> +        #address-cells = <1>;
> +        #size-cells = <0>;
> +
> +        embedded-controller@3b {
> +            compatible = "dell,xps13-9345-ec";
> +            reg = <0x3b>;
> +            interrupts-extended = <&tlmm 66 IRQ_TYPE_LEVEL_LOW>;
> +
> +            io-channels = <&pmk8550_vadc ADC5_GEN3_AMUX3_GPIO_100K_PU(1)>,

[Severity: Low]
Will this example cause make dt_binding_check to fail with a C preprocessor
error?

The included file <arm64/qcom/qcom-adc5-gen3.h> does not seem to exist in the
kernel source tree.

Additionally, the constant macro ADC5_GEN3_AMUX3_GPIO_100K_PU typically does
not take arguments, making the (1) syntax invalid.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260809-dell-xps-9345-ec-v4-0-88306dbbc7aa@vinarskis.com?part=1