Re: [PATCH v4 3/3] arm64: dts: qcom: x1e80100-dell-xps13-9345: introduce EC

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The patch introduces fatal device tree build failures by referencing an undefined label `&pmk8550_vadc` and using an invalid parameterized macro syntax for ADC channel specifiers (e.g., `ADC5_GEN3_AMUX3_GPIO_100K_PU(1)`).
--

--- Patch [3]: [PATCH v4 3/3] arm64: dts: qcom: x1e80100-dell-xps13-9345: introduce EC ---
commit 6743702dcb2539a4e554f58c14ddc3bc1f52a527
Author: Aleksandrs Vinarskis <alex@vinarskis.com>

arm64: dts: qcom: x1e80100-dell-xps13-9345: introduce EC

Describe embedded controller, its interrupt and required thermal zones.
Add EC's reset GPIO to reserved range, as triggering it during device
operation leads to unrecoverable and unusable state.

> diff --git a/arch/arm64/boot/dts/qcom/x1e80100-dell-xps13-9345.dts b/arch/arm64/boot/dts/qcom/x1e80100-dell-xps13-9345.dts
> index ce7b10ea89b6d..8d8d8014049bb 100644
> --- a/arch/arm64/boot/dts/qcom/x1e80100-dell-xps13-9345.dts
> +++ b/arch/arm64/boot/dts/qcom/x1e80100-dell-xps13-9345.dts
[ ... ]
> @@ -759,8 +759,32 @@ retimer_ss0_con_sbu_out: endpoint {
>  
>  &i2c5 {
>  	clock-frequency = <100000>;
> -	status = "disabled";
> -	/* EC @0x3b */
> +	status = "okay";
> +
> +	embedded-controller@3b {
> +		compatible = "dell,xps13-9345-ec";
> +		reg = <0x3b>;
> +
> +		interrupts-extended = <&tlmm 66 IRQ_TYPE_LEVEL_LOW>;
> +
> +		pinctrl-0 = <&ec_int_n_default>;
> +		pinctrl-names = "default";
> +
> +		io-channels = <&pmk8550_vadc ADC5_GEN3_AMUX3_GPIO_100K_PU(1)>,
                               ^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

[Severity: Low]
Does the pmk8550_vadc label exist in any of the included files? It appears this
might be an undefined label, which would break the device tree compilation.

Additionally, are the ADC5_GEN3_AMUX*_PU macros defined to accept parameters?
If they do not, using them with (1) will result in a syntax error when parsed
by dtc.

> +			      <&pmk8550_vadc ADC5_GEN3_AMUX4_GPIO_100K_PU(1)>,
> +			      <&pmk8550_vadc ADC5_GEN3_AMUX1_THM_100K_PU(1)>,
> +			      <&pmk8550_vadc ADC5_GEN3_AMUX2_THM_100K_PU(1)>,
> +			      <&pmk8550_vadc ADC5_GEN3_AMUX3_THM_100K_PU(1)>,
> +			      <&pmk8550_vadc ADC5_GEN3_AMUX4_THM_100K_PU(1)>,
> +			      <&pmk8550_vadc ADC5_GEN3_AMUX5_THM_100K_PU(1)>;
[ ... ]
> @@ -1025,6 +1049,57 @@ rtmr0_1p8_reg_en: rtmr0-1p8-reg-en-state {
>  	};
>  };
>  
> +&pmk8550_vadc {
   ^^^^^^^^^^^^^

[Severity: Low]
Is this attempting to extend a non-existent node? This will also cause a
build failure if pmk8550_vadc is undefined.

> +	sys_therm0: channel@14c {
> +		reg = <ADC5_GEN3_AMUX3_GPIO_100K_PU(1)>;
> +		qcom,hw-settle-time = <200>;
> +		qcom,ratiometric;
> +		label = "lpddr5_therm";
> +	};
> +

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260809-dell-xps-9345-ec-v4-0-88306dbbc7aa@vinarskis.com?part=3