Re: [PATCH v10 1/6] arm64: dts: qcom: Add device tree for Nord SoC series

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [High] Missing 'critical' trip points in thermal zones.
--

--- Patch [1]: [PATCH v10 1/6] arm64: dts: qcom: Add device tree for Nord SoC series ---
commit 2e111a76a0005ef21158cf2e53ba21499ce90eed
Author: Shawn Guo <shengchao.guo@oss.qualcomm.com>
arm64: dts: qcom: Add device tree for Nord SoC series

This commit adds the base device tree include for the Nord SoC series.
It describes core hardware components including Oryon cores, GICv3,
TSENS thermal sensors, and various other controllers.

> diff --git a/arch/arm64/boot/dts/qcom/nord.dtsi b/arch/arm64/boot/dts/qcom/nord.dtsi
> new file mode 100644
> --- /dev/null
> +++ b/arch/arm64/boot/dts/qcom/nord.dtsi
[ ... ]
> +	thermal_zones: thermal-zones {
> +		ddr-0-0-thermal {
> +			polling-delay-passive = <0>;
> +			polling-delay = <0>;
> +			thermal-sensors = <&tsens0 0>;
> +
> +			trips {
> +				trip-point0 {
> +					temperature = <105000>;
> +					hysteresis = <10000>;
> +					type = "passive";
> +				};
> +
> +				trip-point1 {
> +					temperature = <115000>;
> +					hysteresis = <10000>;
> +					type = "passive";
> +				};

[Severity: High]
Should the upper-bound trip points (like trip-point1 here, and throughout
the other thermal zones in this file) be defined as "critical" instead of
"passive"?

If the SoC reaches these peak temperatures (115C or 125C) and passive
cooling fails to mitigate the temperature rise, the thermal framework will
only attempt further passive cooling rather than an emergency shutdown.

Additionally, without a critical trip point, does this prevent the TSENS
hardware driver from properly programming the upper-bound thermal protection
interrupts?

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260810110726.775084-1-shengchao.guo@oss.qualcomm.com?part=1