Re: [PATCH v6 1/9] dt-bindings: soc: qcom: eud: Add per-path child nodes for UTMI routing

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The `oneOf` block allows the new `qcom,sm8350-eud` compatible string to bypass its dual-path requirements by incorrectly matching the legacy single-path `ports` representation.
--

--- Patch [1]: [PATCH v6 1/9] dt-bindings: soc: qcom: eud: Add per-path child nodes for UTMI routing ---
commit de56d6ae0c4dbc79f8a9aa462280cdd2113649b0
Author: Elson Serrao <elson.serrao@oss.qualcomm.com>

dt-bindings: soc: qcom: eud: Add per-path child nodes for UTMI routing

The Qualcomm Embedded USB Debugger (EUD) can intercept one or two High-Speed
UTMI paths depending on the SoC. This commit models each UTMI path as a
separate child node with its own OF graph, adding an SM8350 compatible
while retaining the legacy ports representation for backward compatibility.

> diff --git a/Documentation/devicetree/bindings/soc/qcom/qcom,eud.yaml b/Documentation/devicetree/bindings/soc/qcom/qcom,eud.yaml
> index 84218636c0d8d..0e35bc9a9d20d 100644
> --- a/Documentation/devicetree/bindings/soc/qcom/qcom,eud.yaml
> +++ b/Documentation/devicetree/bindings/soc/qcom/qcom,eud.yaml

[ ... ]

> @@ -45,10 +46,87 @@ properties:
>          $ref: /schemas/graph.yaml#/properties/port
>          description: This port is to be attached to the type C connector.
>  
> +  '#address-cells':
> +    const: 1
> +
> +  '#size-cells':
> +    const: 0

[ ... ]

>  required:
>    - compatible
>    - reg
> -  - ports
> +
> +oneOf:
> +  - required:
> +      - ports
> +    properties:
> +      eud-path@0: false
> +      eud-path@1: false

[Severity: Medium]
Does this first branch of the oneOf block allow the new qcom,sm8350-eud
compatible string to bypass its dual-path requirements?

Because this branch only checks for the presence of the legacy 'ports'
property and the absence of 'eud-path@X', it doesn't restrict the legacy
representation strictly to the legacy qcom,sc7280-eud compatible string.

If a device tree is written for the new SM8350 hardware variant using
the deprecated, single-path 'ports' layout instead of the required
eud-path nodes, it appears it would erroneously pass schema validation by
matching this first branch, entirely avoiding the compatible-based
constraints in the second branch.

> +  - allOf:
> +      - if:
> +          properties:
> +            compatible:
> +              contains:
> +                const: qcom,sc7280-eud
> +        then:
> +          required:
> +            - eud-path@0

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260811213610.2956147-1-elson.serrao@oss.qualcomm.com?part=1