From: Krzysztof Kozlowski <krzk@kernel.org>
To: Jason Yang <jason98166@gmail.com>
Cc: Vinod Koul <vkoul@kernel.org>,
Neil Armstrong <neil.armstrong@linaro.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Heiko Stuebner <heiko@sntech.de>,
Guochun Huang <hero.huang@rock-chips.com>,
Philipp Zabel <p.zabel@pengutronix.de>,
Michael Riesch <michael.riesch@collabora.com>,
Bryan O'Donoghue <bryan.odonoghue@linaro.org>,
linux-phy@lists.infradead.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 2/5] dt-bindings: phy: rockchip,rk3588-mipi-dcphy: allow DSI and CSI consumers
Date: Wed, 12 Aug 2026 12:53:37 +0200 [thread overview]
Message-ID: <20260812-fast-famous-fulmar-3bde7e@quoll> (raw)
In-Reply-To: <20260810-dcphy-rx-v1-v3-2-a2d25c29adfc@gmail.com>
On Mon, Aug 10, 2026 at 08:10:10PM +0800, Jason Yang wrote:
> The Samsung MIPI D-/C-PHY block on RK3588 drives a MIPI DSI
> transmitter and, on the same PHY, can receive from a MIPI CSI camera.
> Describing both as independent consumers of one PHY requires the
> devicetree to tell them apart.
>
> Let the existing single cell also take PHY_TYPE_DSI or PHY_TYPE_CSI,
> selecting the PHY by the protocol the consumer speaks. PHY_TYPE_DPHY
> stays accepted and equivalent to PHY_TYPE_DSI so shipped device trees
> remain valid, and PHY_TYPE_CPHY keeps selecting a C-PHY transmitter.
> The receiver support added by this series is D-PHY only.
>
> Signed-off-by: Jason Yang <jason98166@gmail.com>
> Assisted-by: Claude:claude-fable-5
> ---
> .../devicetree/bindings/phy/rockchip,rk3588-mipi-dcphy.yaml | 11 ++++++++---
> 1 file changed, 8 insertions(+), 3 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/phy/rockchip,rk3588-mipi-dcphy.yaml b/Documentation/devicetree/bindings/phy/rockchip,rk3588-mipi-dcphy.yaml
> index c8ff5ba22a86..1f7c2e2ddfc1 100644
> --- a/Documentation/devicetree/bindings/phy/rockchip,rk3588-mipi-dcphy.yaml
> +++ b/Documentation/devicetree/bindings/phy/rockchip,rk3588-mipi-dcphy.yaml
> @@ -22,9 +22,14 @@ properties:
> "#phy-cells":
> const: 1
> description: |
> - Argument is mode to operate in. Supported modes are:
> - - PHY_TYPE_DPHY
> - - PHY_TYPE_CPHY
> + The block contains a MIPI transmitter and a MIPI receiver, which
> + can be referenced independently. The argument selects one of
> + them:
> + - PHY_TYPE_DSI: the transmitter, for a MIPI DSI host
> + - PHY_TYPE_CSI: the receiver, for a MIPI CSI-2 host
> + - PHY_TYPE_DPHY: the transmitter in D-PHY mode; equivalent to
> + PHY_TYPE_DSI and kept for existing device trees
> + - PHY_TYPE_CPHY: the transmitter in C-PHY mode
So PHY_TYPE_DSI is the same as PHY_TYPE_DPHY. Why doing this change?
Commit msg did not tell me why we need equivalent code.
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-08-12 10:53 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-10 12:10 [PATCH v3 0/5] phy: rockchip-samsung-dcphy: add the MIPI D-PHY receiver Jason Yang via B4 Relay
2026-08-10 12:10 ` [PATCH v3 1/5] dt-bindings: phy: Add PHY_TYPE_DSI and PHY_TYPE_CSI definitions Jason Yang via B4 Relay
2026-08-12 10:51 ` Krzysztof Kozlowski
2026-08-12 12:24 ` 楊智成
2026-08-13 0:02 ` Sebastian Reichel
2026-08-13 4:33 ` 楊智成
2026-08-13 7:59 ` Krzysztof Kozlowski
2026-08-13 8:40 ` 楊智成
2026-08-13 9:25 ` Krzysztof Kozlowski
2026-08-13 8:01 ` Krzysztof Kozlowski
2026-08-10 12:10 ` [PATCH v3 2/5] dt-bindings: phy: rockchip,rk3588-mipi-dcphy: allow DSI and CSI consumers Jason Yang via B4 Relay
2026-08-12 10:53 ` Krzysztof Kozlowski [this message]
2026-08-10 12:10 ` [PATCH v3 3/5] phy: rockchip-samsung-dcphy: factor MIPI D-PHY power on/off into helpers Jason Yang via B4 Relay
2026-08-10 12:10 ` [PATCH v3 4/5] phy: rockchip-samsung-dcphy: model TX and RX as separate PHYs Jason Yang via B4 Relay
2026-08-10 12:10 ` [PATCH v3 5/5] phy: rockchip-samsung-dcphy: add MIPI D-PHY receiver support Jason Yang via B4 Relay
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260812-fast-famous-fulmar-3bde7e@quoll \
--to=krzk@kernel.org \
--cc=bryan.odonoghue@linaro.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=heiko@sntech.de \
--cc=hero.huang@rock-chips.com \
--cc=jason98166@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=michael.riesch@collabora.com \
--cc=neil.armstrong@linaro.org \
--cc=p.zabel@pengutronix.de \
--cc=robh@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox