Devicetree
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Jason Yang <jason98166@gmail.com>
Cc: Vinod Koul <vkoul@kernel.org>,
	 Neil Armstrong <neil.armstrong@linaro.org>,
	Rob Herring <robh@kernel.org>,
	 Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	 Heiko Stuebner <heiko@sntech.de>,
	Guochun Huang <hero.huang@rock-chips.com>,
	 Philipp Zabel <p.zabel@pengutronix.de>,
	Michael Riesch <michael.riesch@collabora.com>,
	 Bryan O'Donoghue <bryan.odonoghue@linaro.org>,
	linux-phy@lists.infradead.org, devicetree@vger.kernel.org,
	 linux-arm-kernel@lists.infradead.org,
	linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 1/5] dt-bindings: phy: Add PHY_TYPE_DSI and PHY_TYPE_CSI definitions
Date: Wed, 12 Aug 2026 12:51:42 +0200	[thread overview]
Message-ID: <20260812-refreshing-rampant-gecko-b38ef9@quoll> (raw)
In-Reply-To: <20260810-dcphy-rx-v1-v3-1-a2d25c29adfc@gmail.com>

On Mon, Aug 10, 2026 at 08:10:09PM +0800, Jason Yang wrote:
> MIPI D-PHY and C-PHY blocks are increasingly direction-agnostic: the
> same PHY IP can drive a MIPI DSI display or receive from a MIPI CSI-2
> camera, and combo blocks like the Samsung IP on RK3588 expose both
> directions to independent consumers at the same time. A binding that
> needs to tell the two consumers apart has nothing generic to reach
> for: most constants in this header name a protocol (PHY_TYPE_USB3,
> PHY_TYPE_DP, ...), while the MIPI entries name only the electrical
> layer.
> 
> Add PHY_TYPE_DSI and PHY_TYPE_CSI to select a PHY by the MIPI
> protocol it speaks, which also implies the direction. They do not
> replace PHY_TYPE_DPHY/PHY_TYPE_CPHY, which remain the right choice
> where the cell selects the electrical layer. First user is the
> Rockchip RK3588 MIPI DC-PHY binding.

I read above, but still do not get why TYPE_DPHY/CPHY is not enough.
Isn't DPHY implying it is DSI?

> 
> Suggested-by: Michael Riesch <michael.riesch@collabora.com>
> Signed-off-by: Jason Yang <jason98166@gmail.com>

Your tag goes the last.

> Assisted-by: Claude:claude-fable-5

Two simple defines needed Claude. Great, that probably makes AI
conglomerates very happy that we do not type even two lines anymore and
need their resource-hungry data centers to do that for us.

Best regards,
Krzysztof


  reply	other threads:[~2026-08-12 10:51 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-10 12:10 [PATCH v3 0/5] phy: rockchip-samsung-dcphy: add the MIPI D-PHY receiver Jason Yang via B4 Relay
2026-08-10 12:10 ` [PATCH v3 1/5] dt-bindings: phy: Add PHY_TYPE_DSI and PHY_TYPE_CSI definitions Jason Yang via B4 Relay
2026-08-12 10:51   ` Krzysztof Kozlowski [this message]
2026-08-12 12:24     ` 楊智成
2026-08-13  0:02       ` Sebastian Reichel
2026-08-13  4:33         ` 楊智成
2026-08-10 12:10 ` [PATCH v3 2/5] dt-bindings: phy: rockchip,rk3588-mipi-dcphy: allow DSI and CSI consumers Jason Yang via B4 Relay
2026-08-12 10:53   ` Krzysztof Kozlowski
2026-08-10 12:10 ` [PATCH v3 3/5] phy: rockchip-samsung-dcphy: factor MIPI D-PHY power on/off into helpers Jason Yang via B4 Relay
2026-08-10 12:10 ` [PATCH v3 4/5] phy: rockchip-samsung-dcphy: model TX and RX as separate PHYs Jason Yang via B4 Relay
2026-08-10 12:10 ` [PATCH v3 5/5] phy: rockchip-samsung-dcphy: add MIPI D-PHY receiver support Jason Yang via B4 Relay

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260812-refreshing-rampant-gecko-b38ef9@quoll \
    --to=krzk@kernel.org \
    --cc=bryan.odonoghue@linaro.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=heiko@sntech.de \
    --cc=hero.huang@rock-chips.com \
    --cc=jason98166@gmail.com \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-phy@lists.infradead.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=michael.riesch@collabora.com \
    --cc=neil.armstrong@linaro.org \
    --cc=p.zabel@pengutronix.de \
    --cc=robh@kernel.org \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox