From: sashiko-bot@kernel.org
To: "Colin Huang" <u8813345@gmail.com>
Cc: devicetree@vger.kernel.org, conor+dt@kernel.org, robh@kernel.org
Subject: Re: [PATCH v5 09/15] ARM: dts: aspeed: anacapa: evt2: Add shunt resistor values for HSC monitors
Date: Thu, 13 Aug 2026 12:04:20 +0000 [thread overview]
Message-ID: <20260813120420.D02181F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260813-anacapa-devlop-phase-devicetree-v5-9-c7058f63dc67@gmail.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Missing Signed-off-by from the patch author.
--
--- Patch [9]: [PATCH v5 09/15] ARM: dts: aspeed: anacapa: evt2: Add shunt resistor values for HSC monitors ---
commit ed139ca587bbe5fe1cadfdeab9c5f4d6712eff09
Author: Colin Huang <u8813345@gmail.com>
ARM: dts: aspeed: anacapa: evt2: Add shunt resistor values for HSC monitors
This commit adds shunt resistor configurations for LTC4287 hot-swap
controllers on the Anacapa EVT2 platform. It configures the values to
150 micro-ohms or 250 micro-ohms depending on the rail to ensure accurate
current and power measurement by the driver.
> Author: Colin Huang <u8813345@gmail.com>
> Date: Thu Aug 13 11:59:39 2026 +0000
>
> ARM: dts: aspeed: anacapa: evt2: Add shunt resistor values for HSC monitors
>
> Add shunt resistor configuration for LTC4287 hot-swap controllers on
> Anacapa EVT2 platform.
[ ... ]
> Without this configuration, the reported readings would be incorrect.
>
> Signed-off-by: Peter Shen <peter.shen@amd.com>
[Severity: Low]
This isn't a bug, but there appears to be a mismatch between the patch
author and the provided sign-offs. Is a Signed-off-by tag from the original
author missing here to satisfy the Developer's Certificate of Origin rules
for kernel submissions?
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260813-anacapa-devlop-phase-devicetree-v5-0-c7058f63dc67@gmail.com?part=9
next prev parent reply other threads:[~2026-08-13 12:04 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-13 11:59 [PATCH v5 00/15] ARM: dts: aspeed: anacapa: restructure devicetree for development-phase Colin Huang via B4 Relay
2026-08-13 11:59 ` [PATCH v5 01/15] dt-bindings: arm: aspeed: Add Anacapa EVT1 EVT2 DVT board Colin Huang via B4 Relay
2026-08-13 11:59 ` [PATCH v5 02/15] ARM: dts: aspeed: anacapa: Add EVT1 devicetree and point wrapper to it Colin Huang via B4 Relay
2026-08-13 12:10 ` sashiko-bot
2026-08-13 11:59 ` [PATCH v5 03/15] ARM: dts: aspeed: anacapa: Add EVT2 devicetree inheriting EVT1 Colin Huang via B4 Relay
2026-08-13 11:59 ` [PATCH v5 04/15] ARM: dts: aspeed: anacapa: Add DVT devicetree inheriting EVT2 Colin Huang via B4 Relay
2026-08-13 11:59 ` [PATCH v5 05/15] ARM: dts: aspeed: anacapa: Add additional EEPROM node for SCM Colin Huang via B4 Relay
2026-08-13 11:59 ` [PATCH v5 06/15] ARM: dts: aspeed: anacapa: Add eeprom device node for NFC adaptor board Colin Huang via B4 Relay
2026-08-13 11:59 ` [PATCH v5 07/15] ARM: dts: aspeed: anacapa: Align PDB fan GPIO numbering Colin Huang via B4 Relay
2026-08-13 11:59 ` [PATCH v5 08/15] ARM: dts: aspeed: anacapa: Enable MCTP and FRU for NIC Colin Huang via B4 Relay
2026-08-13 11:59 ` [PATCH v5 09/15] ARM: dts: aspeed: anacapa: evt2: Add shunt resistor values for HSC monitors Colin Huang via B4 Relay
2026-08-13 12:04 ` sashiko-bot [this message]
2026-08-13 11:59 ` [PATCH v5 10/15] ARM: dts: aspeed: anacapa: Add LPDB fuse monitor GPIO expander Colin Huang via B4 Relay
2026-08-13 11:59 ` [PATCH v5 11/15] ARM: dts: aspeed: anacapa: Simplify leakage GPIO line names Colin Huang via B4 Relay
2026-08-13 11:59 ` [PATCH v5 12/15] ARM: dts: aspeed: anacapa: Add SPI flash VCC supply Colin Huang via B4 Relay
2026-08-13 11:59 ` [PATCH v5 13/15] ARM: dts: aspeed: anacapa: fix dt-check-style strict violations Colin Huang via B4 Relay
2026-08-13 11:59 ` [PATCH v5 14/15] ARM: dts: aspeed: anacapa: Use default SPI2 memory mapping Colin Huang via B4 Relay
2026-08-13 11:59 ` [PATCH v5 15/15] ARM: dts: aspeed: anacapa: Remove redundant vhub pinctrl-names Colin Huang via B4 Relay
2026-08-13 15:12 ` [PATCH v5 00/15] ARM: dts: aspeed: anacapa: restructure devicetree for development-phase Tan Siewert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260813120420.D02181F000E9@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=u8813345@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox