* [PATCH v2 1/2] ARM: dts: ti: keystone: Align devctrl child node names with dtschema
2026-08-15 18:52 [PATCH v2 0/2] ti,keystone-devctrl: Convert to DT schema and DTS cleanups Bhargav Joshi
@ 2026-08-15 18:52 ` Bhargav Joshi
2026-08-15 18:53 ` [PATCH v2 2/2] dt-bindings: mfd: ti,keystone-devctrl: Convert to DT schema Bhargav Joshi
1 sibling, 0 replies; 4+ messages in thread
From: Bhargav Joshi @ 2026-08-15 18:52 UTC (permalink / raw)
To: Lee Jones, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Ivan Khoronzhuk, Nishanth Menon, Santosh Shilimkar
Cc: mfd, devicetree, linux-kernel, goledhruva, m-chawdhry,
daniel.baluta, simona.toaca, j.bhargav.u, linux-arm-kernel
Align TI Keystone device state control child node names with standard
naming conventions.
- Change keystone_irq to interrupt-controller
- Change keystone_dsp_gpio to gpio
Signed-off-by: Bhargav Joshi <j.bhargav.u@gmail.com>
---
arch/arm/boot/dts/ti/keystone/keystone-k2e.dtsi | 2 +-
arch/arm/boot/dts/ti/keystone/keystone-k2g.dtsi | 4 ++--
arch/arm/boot/dts/ti/keystone/keystone-k2hk.dtsi | 16 ++++++++--------
arch/arm/boot/dts/ti/keystone/keystone-k2l.dtsi | 8 ++++----
arch/arm/boot/dts/ti/keystone/keystone.dtsi | 2 +-
5 files changed, 16 insertions(+), 16 deletions(-)
diff --git a/arch/arm/boot/dts/ti/keystone/keystone-k2e.dtsi b/arch/arm/boot/dts/ti/keystone/keystone-k2e.dtsi
index 662aa33cba11..083c94b62fc7 100644
--- a/arch/arm/boot/dts/ti/keystone/keystone-k2e.dtsi
+++ b/arch/arm/boot/dts/ti/keystone/keystone-k2e.dtsi
@@ -110,7 +110,7 @@ pscrst: reset-controller {
};
devctrl: device-state-control@2620000 {
- dspgpio0: keystone_dsp_gpio@240 {
+ dspgpio0: gpio@240 {
compatible = "ti,keystone-dsp-gpio";
reg = <0x240 0x4>;
gpio-controller;
diff --git a/arch/arm/boot/dts/ti/keystone/keystone-k2g.dtsi b/arch/arm/boot/dts/ti/keystone/keystone-k2g.dtsi
index dafe485dfe19..11b27663503a 100644
--- a/arch/arm/boot/dts/ti/keystone/keystone-k2g.dtsi
+++ b/arch/arm/boot/dts/ti/keystone/keystone-k2g.dtsi
@@ -121,7 +121,7 @@ devctrl: device-state-control@2620000 {
#size-cells = <1>;
ranges = <0x0 0x02620000 0x1000>;
- kirq0: keystone_irq@2a0 {
+ kirq0: interrupt-controller@2a0 {
compatible = "ti,keystone-irq";
reg = <0x2a0 0x10>;
interrupts = <GIC_SPI 1 IRQ_TYPE_EDGE_RISING>;
@@ -130,7 +130,7 @@ kirq0: keystone_irq@2a0 {
ti,syscon-dev = <&devctrl 0x2a0>;
};
- dspgpio0: keystone_dsp_gpio@240 {
+ dspgpio0: gpio@240 {
compatible = "ti,keystone-dsp-gpio";
reg = <0x240 0x4>;
gpio-controller;
diff --git a/arch/arm/boot/dts/ti/keystone/keystone-k2hk.dtsi b/arch/arm/boot/dts/ti/keystone/keystone-k2hk.dtsi
index 4fdf4b30384f..b7a9fbd6d59d 100644
--- a/arch/arm/boot/dts/ti/keystone/keystone-k2hk.dtsi
+++ b/arch/arm/boot/dts/ti/keystone/keystone-k2hk.dtsi
@@ -88,7 +88,7 @@ pscrst: reset-controller {
};
devctrl: device-state-control@2620000 {
- dspgpio0: keystone_dsp_gpio@240 {
+ dspgpio0: gpio@240 {
compatible = "ti,keystone-dsp-gpio";
reg = <0x240 0x4>;
gpio-controller;
@@ -96,7 +96,7 @@ dspgpio0: keystone_dsp_gpio@240 {
gpio,syscon-dev = <&devctrl 0x240>;
};
- dspgpio1: keystone_dsp_gpio@244 {
+ dspgpio1: gpio@244 {
compatible = "ti,keystone-dsp-gpio";
reg = <0x244 0x4>;
gpio-controller;
@@ -104,7 +104,7 @@ dspgpio1: keystone_dsp_gpio@244 {
gpio,syscon-dev = <&devctrl 0x244>;
};
- dspgpio2: keystone_dsp_gpio@248 {
+ dspgpio2: gpio@248 {
compatible = "ti,keystone-dsp-gpio";
reg = <0x248 0x4>;
gpio-controller;
@@ -112,7 +112,7 @@ dspgpio2: keystone_dsp_gpio@248 {
gpio,syscon-dev = <&devctrl 0x248>;
};
- dspgpio3: keystone_dsp_gpio@24c {
+ dspgpio3: gpio@24c {
compatible = "ti,keystone-dsp-gpio";
reg = <0x24c 0x4>;
gpio-controller;
@@ -120,7 +120,7 @@ dspgpio3: keystone_dsp_gpio@24c {
gpio,syscon-dev = <&devctrl 0x24c>;
};
- dspgpio4: keystone_dsp_gpio@250 {
+ dspgpio4: gpio@250 {
compatible = "ti,keystone-dsp-gpio";
reg = <0x250 0x4>;
gpio-controller;
@@ -128,7 +128,7 @@ dspgpio4: keystone_dsp_gpio@250 {
gpio,syscon-dev = <&devctrl 0x250>;
};
- dspgpio5: keystone_dsp_gpio@254 {
+ dspgpio5: gpio@254 {
compatible = "ti,keystone-dsp-gpio";
reg = <0x254 0x4>;
gpio-controller;
@@ -136,7 +136,7 @@ dspgpio5: keystone_dsp_gpio@254 {
gpio,syscon-dev = <&devctrl 0x254>;
};
- dspgpio6: keystone_dsp_gpio@258 {
+ dspgpio6: gpio@258 {
compatible = "ti,keystone-dsp-gpio";
reg = <0x258 0x4>;
gpio-controller;
@@ -144,7 +144,7 @@ dspgpio6: keystone_dsp_gpio@258 {
gpio,syscon-dev = <&devctrl 0x258>;
};
- dspgpio7: keystone_dsp_gpio@25c {
+ dspgpio7: gpio@25c {
compatible = "ti,keystone-dsp-gpio";
reg = <0x25c 0x4>;
gpio-controller;
diff --git a/arch/arm/boot/dts/ti/keystone/keystone-k2l.dtsi b/arch/arm/boot/dts/ti/keystone/keystone-k2l.dtsi
index 330b437b667f..4678454c0eb3 100644
--- a/arch/arm/boot/dts/ti/keystone/keystone-k2l.dtsi
+++ b/arch/arm/boot/dts/ti/keystone/keystone-k2l.dtsi
@@ -290,7 +290,7 @@ osr: sram@70000000 {
};
devctrl: device-state-control@2620000 {
- dspgpio0: keystone_dsp_gpio@240 {
+ dspgpio0: gpio@240 {
compatible = "ti,keystone-dsp-gpio";
reg = <0x240 0x4>;
gpio-controller;
@@ -298,7 +298,7 @@ dspgpio0: keystone_dsp_gpio@240 {
gpio,syscon-dev = <&devctrl 0x240>;
};
- dspgpio1: keystone_dsp_gpio@244 {
+ dspgpio1: gpio@244 {
compatible = "ti,keystone-dsp-gpio";
reg = <0x244 0x4>;
gpio-controller;
@@ -306,7 +306,7 @@ dspgpio1: keystone_dsp_gpio@244 {
gpio,syscon-dev = <&devctrl 0x244>;
};
- dspgpio2: keystone_dsp_gpio@248 {
+ dspgpio2: gpio@248 {
compatible = "ti,keystone-dsp-gpio";
reg = <0x248 0x4>;
gpio-controller;
@@ -314,7 +314,7 @@ dspgpio2: keystone_dsp_gpio@248 {
gpio,syscon-dev = <&devctrl 0x248>;
};
- dspgpio3: keystone_dsp_gpio@24c {
+ dspgpio3: gpio@24c {
compatible = "ti,keystone-dsp-gpio";
reg = <0x24c 0x4>;
gpio-controller;
diff --git a/arch/arm/boot/dts/ti/keystone/keystone.dtsi b/arch/arm/boot/dts/ti/keystone/keystone.dtsi
index ff16428860a9..20596fa446b9 100644
--- a/arch/arm/boot/dts/ti/keystone/keystone.dtsi
+++ b/arch/arm/boot/dts/ti/keystone/keystone.dtsi
@@ -93,7 +93,7 @@ devctrl: device-state-control@2620000 {
#size-cells = <1>;
ranges = <0x0 0x02620000 0x1000>;
- kirq0: keystone_irq@2a0 {
+ kirq0: interrupt-controller@2a0 {
compatible = "ti,keystone-irq";
reg = <0x2a0 0x4>;
interrupts = <GIC_SPI 4 IRQ_TYPE_EDGE_RISING>;
--
2.55.0
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH v2 2/2] dt-bindings: mfd: ti,keystone-devctrl: Convert to DT schema
2026-08-15 18:52 [PATCH v2 0/2] ti,keystone-devctrl: Convert to DT schema and DTS cleanups Bhargav Joshi
2026-08-15 18:52 ` [PATCH v2 1/2] ARM: dts: ti: keystone: Align devctrl child node names with dtschema Bhargav Joshi
@ 2026-08-15 18:53 ` Bhargav Joshi
2026-08-15 19:00 ` sashiko-bot
1 sibling, 1 reply; 4+ messages in thread
From: Bhargav Joshi @ 2026-08-15 18:53 UTC (permalink / raw)
To: Lee Jones, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Ivan Khoronzhuk, Nishanth Menon, Santosh Shilimkar
Cc: mfd, devicetree, linux-kernel, goledhruva, m-chawdhry,
daniel.baluta, simona.toaca, j.bhargav.u, linux-arm-kernel
Convert the Texas Instruments Keystone Device State Control binding from
legacy text format to DT schema.
During the conversion, the following updates were made:
- Add "simple-mfd" to compatibles matching existing dts usage.
- Add required bus properties #address-cells, #size-cells, and ranges
which were missing in text binding.
- Document child nodes gpio, interrupt-controller, and reset-controller.
Signed-off-by: Bhargav Joshi <j.bhargav.u@gmail.com>
---
Note: Running dt_binding_check on patch will yield a warning for
'ti,keystone-reset' in the example block. The YAML conversion patch for
that child node is already in progress here:
https://lore.kernel.org/linux-devicetree/20260813-ti-keystone-reset-v1-1-189389503324@gmail.com/
---
.../bindings/mfd/ti,keystone-devctrl.yaml | 84 ++++++++++++++++++++++
.../bindings/mfd/ti-keystone-devctrl.txt | 19 -----
2 files changed, 84 insertions(+), 19 deletions(-)
diff --git a/Documentation/devicetree/bindings/mfd/ti,keystone-devctrl.yaml b/Documentation/devicetree/bindings/mfd/ti,keystone-devctrl.yaml
new file mode 100644
index 000000000000..dd73b62357ca
--- /dev/null
+++ b/Documentation/devicetree/bindings/mfd/ti,keystone-devctrl.yaml
@@ -0,0 +1,84 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/mfd/ti,keystone-devctrl.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Texas Instruments Keystone Device State Control
+
+maintainers:
+ - Ivan Khoronzhuk <ivan.khoronzhuk@ti.com>
+
+description:
+ The Keystone II devices have a set of registers that are used to control the
+ status of its peripherals. This node is intended to allow access to this
+ functionality.
+
+properties:
+ compatible:
+ items:
+ - const: ti,keystone-devctrl
+ - const: syscon
+ - const: simple-mfd
+
+ reg:
+ maxItems: 1
+
+ "#address-cells":
+ const: 1
+
+ "#size-cells":
+ const: 1
+
+ ranges: true
+
+patternProperties:
+ "^gpio@[0-9a-f]+$":
+ type: object
+ description: Keystone DSP GPIO controller
+
+ "^interrupt-controller@[0-9a-f]+$":
+ type: object
+ description: Keystone DSP to ARM interrupt controller
+
+ "^reset-controller@[0-9a-f]+$":
+ type: object
+ description: Keystone reset controller
+
+required:
+ - compatible
+ - reg
+ - "#address-cells"
+ - "#size-cells"
+ - ranges
+
+additionalProperties: false
+
+examples:
+ - |
+ #include <dt-bindings/interrupt-controller/arm-gic.h>
+
+ device-state-control@2620000 {
+ compatible = "ti,keystone-devctrl", "syscon", "simple-mfd";
+ reg = <0x02620000 0x1000>;
+ #address-cells = <1>;
+ #size-cells = <1>;
+ ranges = <0x0 0x02620000 0x1000>;
+
+ interrupt-controller@2a0 {
+ compatible = "ti,keystone-irq";
+ reg = <0x2a0 0x4>;
+ interrupts = <GIC_SPI 4 IRQ_TYPE_EDGE_RISING>;
+ interrupt-controller;
+ #interrupt-cells = <1>;
+ ti,syscon-dev = <&devctrl 0x2a0>;
+ };
+
+ reset-controller@328 {
+ compatible = "ti,keystone-reset";
+ reg = <0x328 0x10>;
+ ti,syscon-pll = <&pllctrl 0xe4>;
+ ti,syscon-dev = <&devctrl 0x328>;
+ ti,wdt-list = <0>;
+ };
+ };
diff --git a/Documentation/devicetree/bindings/mfd/ti-keystone-devctrl.txt b/Documentation/devicetree/bindings/mfd/ti-keystone-devctrl.txt
deleted file mode 100644
index 71a1f5963936..000000000000
--- a/Documentation/devicetree/bindings/mfd/ti-keystone-devctrl.txt
+++ /dev/null
@@ -1,19 +0,0 @@
-* Device tree bindings for Texas Instruments keystone device state control
-
-The Keystone II devices have a set of registers that are used to control
-the status of its peripherals. This node is intended to allow access to
-this functionality.
-
-Required properties:
-
-- compatible: "ti,keystone-devctrl", "syscon"
-
-- reg: contains offset/length value for device state control
- registers space.
-
-Example:
-
-devctrl: device-state-control@02620000 {
- compatible = "ti,keystone-devctrl", "syscon";
- reg = <0x02620000 0x1000>;
-};
--
2.55.0
^ permalink raw reply related [flat|nested] 4+ messages in thread