Re: [PATCH 1/2] ARM: dts: ti: keystone-k2l: Remove obsolete ti,davinci-spi-num-cs property

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Removing `ti,davinci-spi-num-cs` without replacing it with the standard `num-cs` property permanently discards the correct hardware capability limits, such as the 5 chip selects for `spi2`.
--

--- Patch [1]: [PATCH 1/2] ARM: dts: ti: keystone-k2l: Remove obsolete ti,davinci-spi-num-cs property ---
commit 09741cd34d52c73b4d50caafab226d5b1bedeba4
Author: Bhargav Joshi <j.bhargav.u@gmail.com>

ARM: dts: ti: keystone-k2l: Remove obsolete ti,davinci-spi-num-cs property

The commit removes the obsolete ti,davinci-spi-num-cs property from the SPI
nodes in keystone-k2l.dtsi, as it is not documented or used by the driver.
The driver relies on the standard num-cs property instead.

> diff --git a/arch/arm/boot/dts/ti/keystone/keystone-k2l.dtsi b/arch/arm/boot/dts/ti/keystone/keystone-k2l.dtsi
> index 330b437b667f6..65fdb45e83681 100644
> --- a/arch/arm/boot/dts/ti/keystone/keystone-k2l.dtsi
> +++ b/arch/arm/boot/dts/ti/keystone/keystone-k2l.dtsi
> @@ -400,16 +400,7 @@ mdio: mdio@26200f00 {
>  		/include/ "keystone-k2l-netcp.dtsi"
>  };
>  
> -&spi0 {
> -       ti,davinci-spi-num-cs = <5>;
> -};
> -
> -&spi1 {
> -       ti,davinci-spi-num-cs = <3>;
> -};
> -
>  &spi2 {
> -       ti,davinci-spi-num-cs = <5>;

[Severity: Medium]
Does removing this property instead of converting it to the standard num-cs
property permanently discard the correct hardware limits?

By removing the property entirely, these nodes will silently inherit the default
num-cs = <4> from keystone.dtsi. This discards the intended capabilities
(5 chip selects for spi0/spi2, 3 for spi1) rather than fixing them. The file
itself documents SPI2CS4 (the 5th chip select) for spi2 pinmux.

Should these be replaced with num-cs = <5> and num-cs = <3> respectively?

>         /* Pin muxed. Enabled and configured by Bootloader */
>         status = "disabled";
>  };

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260816-ti-davinci-spi-v1-0-a7f57dfd5262@gmail.com?part=1