[PATCH 0/2] Hi there,

[PATCH 0/2] Hi there,

[Aiden Isik via B4 Relay]

This patchset adds support for the Exynos5515 SoC's chipid to the
chipid driver, and documents the samsung,exynos5515-chipid compatible.

Kind regards,
- Aiden Isik

Signed-off-by: Aiden Isik <aidenisik+git@member.fsf.org>
---
Aiden Isik (2):
      dt-bindings: hwinfo: samsung,exynos-chipid: Add exynos5515 compatible
      soc: samsung: exynos-chipid: Add exynos5515 SoC support

 Documentation/devicetree/bindings/hwinfo/samsung,exynos-chipid.yaml | 1 +
 drivers/soc/samsung/exynos-chipid.c                                 | 1 +
 2 files changed, 2 insertions(+)
---
base-commit: acde40ba506aae78633e080b5704d33cf4bc13c6
change-id: 20260815-for-next-lucky7-chipid-ecce496c86b9

Best regards,
--  
Aiden Isik <aidenisik@member.fsf.org>

[PATCH 1/2] dt-bindings: hwinfo: samsung,exynos-chipid: Add exynos5515 compatible

[Aiden Isik via B4 Relay]

From: Aiden Isik <aidenisik@member.fsf.org>

Add "samsung,exynos5515-chipid" compatible string to binding document.
Use the "samsung,exynos850-chipid" compatible, as it is the same on that
SoC as exynos5515.

Signed-off-by: Aiden Isik <aidenisik+git@member.fsf.org>
---
 Documentation/devicetree/bindings/hwinfo/samsung,exynos-chipid.yaml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/hwinfo/samsung,exynos-chipid.yaml b/Documentation/devicetree/bindings/hwinfo/samsung,exynos-chipid.yaml
index b9cdfe52b62f..619faf33214b 100644
--- a/Documentation/devicetree/bindings/hwinfo/samsung,exynos-chipid.yaml
+++ b/Documentation/devicetree/bindings/hwinfo/samsung,exynos-chipid.yaml
@@ -25,6 +25,7 @@ properties:
       - items:
           - enum:
               - samsung,exynos2200-chipid
+              - samsung,exynos5515-chipid
               - samsung,exynos7885-chipid
               - samsung,exynos8895-chipid
               - samsung,exynos9610-chipid

-- 
2.54.0

Re: [PATCH 1/2] dt-bindings: hwinfo: samsung,exynos-chipid: Add exynos5515 compatible

[sashiko-bot]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Incomplete support for Exynos 5515 causes driver probe failure
--

--- Patch [1]: [PATCH 1/2] dt-bindings: hwinfo: samsung,exynos-chipid: Add exynos5515 compatible ---
commit 5ce6d6fa94d63e1a87277e33f24686ff951995c4
Author: Aiden Isik <aidenisik@member.fsf.org>

dt-bindings: hwinfo: samsung,exynos-chipid: Add exynos5515 compatible

This commit adds the samsung,exynos5515-chipid compatible string to the
exynos-chipid device tree binding. It specifies that it should use the
samsung,exynos850-chipid compatible string as a fallback.

> diff --git a/Documentation/devicetree/bindings/hwinfo/samsung,exynos-chipid.yaml b/Documentation/devicetree/bindings/hwinfo/samsung,exynos-chipid.yaml
> index b9cdfe52b62ff..619faf33214bd 100644
> --- a/Documentation/devicetree/bindings/hwinfo/samsung,exynos-chipid.yaml
> +++ b/Documentation/devicetree/bindings/hwinfo/samsung,exynos-chipid.yaml
> @@ -25,6 +25,7 @@ properties:
>        - items:
>            - enum:
>                - samsung,exynos2200-chipid
> +              - samsung,exynos5515-chipid

[Severity: Medium]
Will this compatible string cause a probe failure on Exynos 5515 hardware?

Because this binding uses the samsung,exynos850-chipid fallback, the
exynos-chipid driver will attempt to probe on Exynos 5515 hardware.
However, if the Exynos 5515 product ID is not added to the soc_ids array
in drivers/soc/samsung/exynos-chipid.c, exynos_product_id_to_name() will
return NULL:

drivers/soc/samsung/exynos-chipid.c:exynos_chipid_probe() {
    ...
    soc_dev_attr->soc_id = exynos_product_id_to_name(soc_info.product_id);
    if (!soc_dev_attr->soc_id)
        return dev_err_probe(dev, -ENODEV, "Unknown SoC\n");
    ...
}

Does the driver need a companion patch to add the Exynos 5515 product ID
so that it can successfully probe rather than returning -ENODEV?

>                - samsung,exynos7885-chipid
>                - samsung,exynos8895-chipid
>                - samsung,exynos9610-chipid

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260817-for-next-lucky7-chipid-v1-0-eb2908705c0d@member.fsf.org?part=1

Re: [PATCH 1/2] dt-bindings: hwinfo: samsung,exynos-chipid: Add exynos5515 compatible

[Aiden Isik]

> Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
> - [Medium] Incomplete support for Exynos 5515 causes driver probe failure
> --
> 
> --- Patch [1]: [PATCH 1/2] dt-bindings: hwinfo: samsung,exynos-chipid: Add exynos5515 compatible ---
> commit 5ce6d6fa94d63e1a87277e33f24686ff951995c4
> Author: Aiden Isik <aidenisik@member.fsf.org>
> 
> dt-bindings: hwinfo: samsung,exynos-chipid: Add exynos5515 compatible
> 
> This commit adds the samsung,exynos5515-chipid compatible string to the
> exynos-chipid device tree binding. It specifies that it should use the
> samsung,exynos850-chipid compatible string as a fallback.
> 
> > diff --git a/Documentation/devicetree/bindings/hwinfo/samsung,exynos-chipid.yaml b/Documentation/devicetree/bindings/hwinfo/samsung,exynos-chipid.yaml
> > index b9cdfe52b62ff..619faf33214bd 100644
> > --- a/Documentation/devicetree/bindings/hwinfo/samsung,exynos-chipid.yaml
> > +++ b/Documentation/devicetree/bindings/hwinfo/samsung,exynos-chipid.yaml
> > @@ -25,6 +25,7 @@ properties:
> >        - items:
> >            - enum:
> >                - samsung,exynos2200-chipid
> > +              - samsung,exynos5515-chipid
> 
> [Severity: Medium]
> Will this compatible string cause a probe failure on Exynos 5515 hardware?
> 
> Because this binding uses the samsung,exynos850-chipid fallback, the
> exynos-chipid driver will attempt to probe on Exynos 5515 hardware.
> However, if the Exynos 5515 product ID is not added to the soc_ids array
> in drivers/soc/samsung/exynos-chipid.c, exynos_product_id_to_name() will
> return NULL:
> 
> drivers/soc/samsung/exynos-chipid.c:exynos_chipid_probe() {
>     ...
>     soc_dev_attr->soc_id = exynos_product_id_to_name(soc_info.product_id);
>     if (!soc_dev_attr->soc_id)
>         return dev_err_probe(dev, -ENODEV, "Unknown SoC\n");
>     ...
> }
> 
> Does the driver need a companion patch to add the Exynos 5515 product ID
> so that it can successfully probe rather than returning -ENODEV?
> 
> >                - samsung,exynos7885-chipid
> >                - samsung,exynos8895-chipid
> >                - samsung,exynos9610-chipid
> 
> --

The Exynos5515 device tree also uses samsung,exynos850 chipid, just like every other 850-compatible-chipid device tree.

> Sashiko AI review · https://sashiko.dev/#/patchset/20260817-for-next-lucky7-chipid-v1-0-eb2908705c0d@member.fsf.org?part=1
>

Re: [PATCH 1/2] dt-bindings: hwinfo: samsung,exynos-chipid: Add exynos5515 compatible

[Krzysztof Kozlowski]

On 17/08/2026 12:11, Aiden Isik via B4 Relay wrote:
> From: Aiden Isik <aidenisik@member.fsf.org>
> 
> Add "samsung,exynos5515-chipid" compatible string to binding document.
> Use the "samsung,exynos850-chipid" compatible, as it is the same on that
> SoC as exynos5515.

I do not see how you use "samsung,exynos850-chipid", probably you meant
that devices are compatible? Just say that you add Exynos5515 ChipID
fully compatible with foo bar (no differences in registers) instead of
repeating the diff.

s/exynos5515/Exynos5515/, in every commit msg

Best regards,
Krzysztof

Re: [PATCH 1/2] dt-bindings: hwinfo: samsung,exynos-chipid: Add exynos5515 compatible

[Aiden Isik]

Hi Krzysztof,

> > Add "samsung,exynos5515-chipid" compatible string to binding document.
> > Use the "samsung,exynos850-chipid" compatible, as it is the same on that
> > SoC as exynos5515.

> I do not see how you use "samsung,exynos850-chipid", probably you meant
> that devices are compatible? Just say that you add Exynos5515 ChipID
> fully compatible with foo bar (no differences in registers) instead of
> repeating the diff.

That is exactly what I meant, will fix in v2.

> s/exynos5515/Exynos5515/, in every commit msg

Will fix in v2. Thanks.

> Best regards,
> Krzysztof

Kind regards,
- Aiden Isik

[PATCH 2/2] soc: samsung: exynos-chipid: Add exynos5515 SoC support

[Aiden Isik via B4 Relay]

From: Aiden Isik <aidenisik@member.fsf.org>

Add exynos5515 information to the soc_ids table.
The chipid for exynos5515 is "0xE5515000".

Signed-off-by: Aiden Isik <aidenisik+git@member.fsf.org>
---
 drivers/soc/samsung/exynos-chipid.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/soc/samsung/exynos-chipid.c b/drivers/soc/samsung/exynos-chipid.c
index 6ef9751e2509..506a0bcdfe30 100644
--- a/drivers/soc/samsung/exynos-chipid.c
+++ b/drivers/soc/samsung/exynos-chipid.c
@@ -64,6 +64,7 @@ static const struct exynos_soc_id {
 	{ "EXYNOS8890", 0xE8890000 },
 	/* Compatible with: samsung,exynos850-chipid */
 	{ "EXYNOS2200", 0xE9925000 },
+	{ "EXYNOS5515", 0xE5515000 },
 	{ "EXYNOS7885", 0xE7885000 },
 	{ "EXYNOS850", 0xE3830000 },
 	{ "EXYNOS8895", 0xE8895000 },

-- 
2.54.0