Re: [PATCH v5 02/12] dt-bindings: mfd: syscon: add Ambarella CV75 secure scratchpad

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The new compatible string `ambarella,cv75-sec-scratchpad` was added to the `properties:compatible` definition but was omitted from the schema's top-level `select:properties:compatible:contains:enum` list.
--

--- Patch [2]: [PATCH v5 02/12] dt-bindings: mfd: syscon: add Ambarella CV75 secure scratchpad ---
commit 2e61d4a5b3f63c115582c6eb092f0bbc87c52d87
Author: Long Zhao <longzhao@ambarella.com>

dt-bindings: mfd: syscon: add Ambarella CV75 secure scratchpad

This commit adds the ambarella,cv75-sec-scratchpad compatible string to
the syscon device tree bindings schema.

> diff --git a/Documentation/devicetree/bindings/mfd/syscon.yaml b/Documentation/devicetree/bindings/mfd/syscon.yaml
> index e228670880631..05c7f59aba5de 100644
> --- a/Documentation/devicetree/bindings/mfd/syscon.yaml
> +++ b/Documentation/devicetree/bindings/mfd/syscon.yaml
> @@ -148,6 +148,7 @@ properties:
>                - allwinner,sun50i-a64-system-controller
>                - altr,l3regs
>                - altr,sdr-ctl
> +              - ambarella,cv75-sec-scratchpad
>                - amd,pensando-elba-syscon
>                - amlogic,meson-mx-assist
>                - amlogic,meson-mx-bootrom

[Severity: Low]
Does this new compatible string also need to be added to the top-level
select list?

Looking at Documentation/devicetree/bindings/mfd/syscon.yaml, the schema
relies on a select list to trigger validation:

select:
  properties:
    compatible:
      contains:
        enum:
          - airoha,en7581-pbus-csr
          ...
          - altr,sdr-ctl
          - amd,pensando-elba-syscon

Without being added to this list alongside the other compatible strings,
could device tree nodes using "ambarella,cv75-sec-scratchpad" bypass dtbs_check
validation entirely, allowing invalid device trees to silently pass?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260818-cv75-v5-v5-0-7bbb12f0360f@ambarella.com?part=2