Re: [PATCH v3 3/5] dt-bindings: iio: pressure: Add MS5637

[Conor Dooley <conor@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 5824 bytes --]

On Thu, Aug 20, 2026 at 10:12:18AM -0400, Louis Adamian wrote:
> Create meas,ms5637 devicetree binding and move existing devices from
> trivial-devices.yaml. Explicit compatible strings are added for the
> different sub-variants because each requires different constants for the
> second-order temperature compensation formulas. Previously, the driver
> exposed the generic compatibles for the ms5637, MS5803, MS5805
> and MS5837 families and applied the MS5637-02BA compensation to all of
> them. To preserve the DT ABI the existing compatibles are retained and
> mapped to the -02BA variant of each family (ms5637-02ba, ms5803-02ba,
> ms5837-02ba).
> 
> Signed-off-by: Louis Adamian <adamianlouis@gmail.com>

Firstly, please CC everyone on all the mails - or at least all the dt
maintainers on all mails, so we don't have to go look at the context on
lore.

Additionally, lore didn't even get your cover letter:
https://lore.kernel.org/all/20260820141224.23730-1-adamianlouis@gmail.com/

The patch itself seems okay. You could probably have made the
ms5637-02ba fall back to the ms5637, but that's more a matter of taste I
think than a technical thing.

Reviewed-by: Conor Dooley <conor.dooley@microchip.com>
pw-bot: not-applicable

Thanks,
Conor.

> ---
>  .../bindings/iio/pressure/meas,ms5637.yaml    | 93 +++++++++++++++++++
>  .../devicetree/bindings/trivial-devices.yaml  | 10 --
>  2 files changed, 93 insertions(+), 10 deletions(-)
>  create mode 100644 Documentation/devicetree/bindings/iio/pressure/meas,ms5637.yaml
> 
> diff --git a/Documentation/devicetree/bindings/iio/pressure/meas,ms5637.yaml b/Documentation/devicetree/bindings/iio/pressure/meas,ms5637.yaml
> new file mode 100644
> index 000000000000..befd81d1907b
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/pressure/meas,ms5637.yaml
> @@ -0,0 +1,93 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/iio/pressure/meas,ms5637.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +title: Measurement Specialties ms5637 and similar pressure sensors
> +
> +maintainers:
> +  - Louis Adamian <adamianlouis@gmail.com>
> +
> +description:
> +  Measurement Specialties pressure and temperature sensors. The MS5803
> +  family supports both I2C and SPI interfaces. All other variants are I2C only.
> +
> +properties:
> +  compatible:
> +    oneOf:
> +      - enum:
> +          - meas,ms5637-02ba
> +          - meas,ms5637-30ba
> +          - meas,ms5803-01ba
> +          - meas,ms5803-02ba
> +          - meas,ms5803-05ba
> +          - meas,ms5803-14ba
> +          - meas,ms5803-30ba
> +          - meas,ms5805
> +          - meas,ms5837-02ba
> +          - meas,ms5837-30ba
> +          - meas,ms8607-temppressure
> +      # These generic compatible strings do not identify the sub-variants of
> +      # the part. They are retained so that existing device trees continue
> +      # to bind, and each is treated as the -02BA variant of its family.
> +      - enum:
> +          - meas,ms5637
> +          - meas,ms5803
> +          - meas,ms5837
> +        deprecated: true
> +
> +  reg:
> +    maxItems: 1
> +
> +  vdd-supply:
> +    description: Regulator that provides power to the sensor
> +
> +required:
> +  - compatible
> +  - reg
> +  - vdd-supply
> +
> +allOf:
> +  - if:
> +      properties:
> +        compatible:
> +          contains:
> +            enum:
> +              - meas,ms5803
> +              - meas,ms5803-01ba
> +              - meas,ms5803-02ba
> +              - meas,ms5803-05ba
> +              - meas,ms5803-14ba
> +              - meas,ms5803-30ba
> +    then:
> +      $ref: /schemas/spi/spi-peripheral-props.yaml#
> +      properties:
> +        spi-max-frequency:
> +          maximum: 20000000
> +
> +unevaluatedProperties: false
> +
> +examples:
> +  - |
> +    i2c {
> +        #address-cells = <1>;
> +        #size-cells = <0>;
> +
> +        pressure@76 {
> +            compatible = "meas,ms5637-02ba";
> +            reg = <0x76>;
> +            vdd-supply = <&vcc_3v3>;
> +        };
> +    };
> +  - |
> +    spi {
> +        #address-cells = <1>;
> +        #size-cells = <0>;
> +
> +        pressure@0 {
> +            compatible = "meas,ms5803-14ba";
> +            reg = <0>;
> +            vdd-supply = <&vcc_3v3>;
> +            spi-max-frequency = <20000000>;
> +        };
> +    };
> diff --git a/Documentation/devicetree/bindings/trivial-devices.yaml b/Documentation/devicetree/bindings/trivial-devices.yaml
> index 435c4baab436..2671040e8802 100644
> --- a/Documentation/devicetree/bindings/trivial-devices.yaml
> +++ b/Documentation/devicetree/bindings/trivial-devices.yaml
> @@ -240,18 +240,8 @@ properties:
>            - meas,htu21
>              # Measurement Specialities I2C temperature and humidity sensor
>            - meas,htu31
> -            # Measurement Specialities I2C pressure and temperature sensor
> -          - meas,ms5637
> -            # Measurement Specialities I2C pressure and temperature sensor
> -          - meas,ms5803
> -            # Measurement Specialities I2C pressure and temperature sensor
> -          - meas,ms5805
> -            # Measurement Specialities I2C pressure and temperature sensor
> -          - meas,ms5837
>              # Measurement Specialities temp and humidity part of ms8607 device
>            - meas,ms8607-humidity
> -            # Measurement Specialities temp and pressure part of ms8607 device
> -          - meas,ms8607-temppressure
>              # Measurement Specialties temperature sensor
>            - meas,tsys01
>              # MEMSIC magnetometer
> -- 
> 2.55.0
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]