Re: [PATCH 7/7] dt-bindings: beagle: Add BeagleConnect Freedom

[Conor Dooley <conor@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 2595 bytes --]

On Thu, Aug 20, 2026 at 02:55:49PM +0530, Ayush Singh wrote:
> Add devicetree bindings for the BeagleBoard.org BeagleConnect Freedom,
> a wireless-enabled board based on the TI CC1352P7. The board exposes an
> MCU that can be attached to a host over USB, UART, SPI or I2C, and is
> described as a child node of the corresponding bus.
> 
> Signed-off-by: Ayush Singh <ayush@beagleboard.org>
> ---
>  .../beagle/beagle,beagleconnect-freedom.yaml       | 30 ++++++++++++++++++++++
>  MAINTAINERS                                        |  1 +
>  2 files changed, 31 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/beagle/beagle,beagleconnect-freedom.yaml b/Documentation/devicetree/bindings/beagle/beagle,beagleconnect-freedom.yaml
> new file mode 100644
> index 000000000000..5a246f81261e
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/beagle/beagle,beagleconnect-freedom.yaml
> @@ -0,0 +1,30 @@
> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/beagle/beagle,beagleconnect-freedom.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: BeagleBoard.org BeagleConnect Freedom
> +
> +description:
> +  The BeagleBoard.org BeagleConnect Freedom board connected over USB, UART, SPI or I2C.
> +
> +maintainers:
> +  - Ayush Singh <ayush@beagleboard.org>
> +
> +properties:
> +  compatible:
> +    const: beagle,beagleconnect-freedom

These compatible only devices always look suspect to me, I feel like
these things probably at least have an optional regulator if the power
source for the freedom is provided by the device running linux.

You're also short the required properties for dealing with anything
other than uart, so spi or i2c. (I assume USB doesn't need devicetree to
function).

pw-bot: changes-requested

Thanks,
Conor.

> +
> +required:
> +  - compatible
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    serial {
> +      mcu {
> +        compatible = "beagle,beagleconnect-freedom";
> +      };
> +    };
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 037a87b74800..49c6dac72748 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -11338,6 +11338,7 @@ GREYBUS UART NODE DRIVERS
>  M:	Ayush Singh <ayush@beagleboard.com>
>  L:	greybus-dev@lists.linaro.org (moderated for non-subscribers)
>  S:	Maintained
> +F:	Documentation/devicetree/bindings/beagle/beagle,beagleconnect-freedom.yaml
>  F:	drivers/greybus/gb_uart_node.rs
>  
>  GREYBUS SUBSYSTEM
> 
> -- 
> 2.55.0
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]