[PATCH 0/3] ARM: dts: stm32: Fix STM32MP1 ev and dk USB onboard HUB supplies

[PATCH 0/3] ARM: dts: stm32: Fix STM32MP1 ev and dk USB onboard HUB supplies

[Fabrice Gasnier]

Some STM32 boards use Microchip USB2514 HUB. Since vdda supply has been
added, the regulator framework wrongly associates the 'vdda' supply
dedicated to ADC, so the wrong regulator is referenced.
Only the 3v3 regulator is used to supply both the digital and the analog
part of the HUB.

Before this series:
cat /sys/kernel/debug/regulator/regulator_summary
...
    v3v3                         10    9      0  normal  3300mV     0mA  3300mV  3300mV
...
       5800d000.usb:hub@1-vdd     1                                 0mA     0mV     0mV
...
    vdda                          1    1      0 unknown  2900mV     0mA  2900mV  2900mV
       5800d000.usb:hub@1-vdda    1                                 0mA     0mV     0mV

After:
    v3v3                         11   10      0  normal  3300mV     0mA  3300mV  3300mV
...
       5800d000.usb:hub@1-vdda    1                                 0mA     0mV     0mV
       5800d000.usb:hub@1-vdd     1                                 0mA     0mV     0mV
...
    vdda                          0    0      0 unknown  2900mV     0mA  2900mV  2900mV

---
Fabrice Gasnier (3):
      ARM: dts: stm32: fix vdda supply for onboard hub on stm32mp15 DK boards
      ARM: dts: stm32: fix vdda supply for onboard hub on stm32mp157c-ev1
      ARM: dts: stm32: fix vdda supply for onboard hub on stm32mp135f-dk

 arch/arm/boot/dts/st/stm32mp135f-dk.dts   | 1 +
 arch/arm/boot/dts/st/stm32mp157c-ev1.dts  | 1 +
 arch/arm/boot/dts/st/stm32mp15xx-dkx.dtsi | 1 +
 3 files changed, 3 insertions(+)
---
base-commit: 8d3ae59288f1e7d58d76558a6ee96d533bc5019f
change-id: 20260821-usb_fixes_vdda-v1-0e5eea790b2a

Best regards,
--  
Fabrice Gasnier <fabrice.gasnier@foss.st.com>

[PATCH 1/3] ARM: dts: stm32: fix vdda supply for onboard hub on stm32mp15 DK boards

[Fabrice Gasnier]

stm32mp15 DK boards use Microchip USB2514 HUB. Since vdda supply has been
added, the regulator framework wrongly associates the 'vdda' supply
dedicated to ADC, so the wrong regulator is referenced.
Only the 3v3 regulator is used to supply both the digital and the analog
part of the HUB.

Fixes: 673655f7944f ("usb: misc: onboard_dev: add vdda support for Microchip USB2514")
Signed-off-by: Gabriel Fernandez <gabriel.fernandez@foss.st.com>
Signed-off-by: Fabrice Gasnier <fabrice.gasnier@foss.st.com>
---
 arch/arm/boot/dts/st/stm32mp15xx-dkx.dtsi | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm/boot/dts/st/stm32mp15xx-dkx.dtsi b/arch/arm/boot/dts/st/stm32mp15xx-dkx.dtsi
index 599ea07bdb19..01ac3d7d6d0e 100644
--- a/arch/arm/boot/dts/st/stm32mp15xx-dkx.dtsi
+++ b/arch/arm/boot/dts/st/stm32mp15xx-dkx.dtsi
@@ -764,6 +764,7 @@ hub@1 {
 		compatible = "usb424,2514";
 		reg = <1>;
 		vdd-supply = <&v3v3>;
+		vdda-supply = <&v3v3>;
 	};
 };
 

-- 
2.43.0

[PATCH 2/3] ARM: dts: stm32: fix vdda supply for onboard hub on stm32mp157c-ev1

[Fabrice Gasnier]

stm32mp157c-ev1 uses Microchip USB2514 HUB. Since vdda supply has been
added, the regulator framework wrongly associates the 'vdda' supply
dedicated to ADC, so the wrong regulator is referenced.
Only the 3v3 regulator is used to supply both the digital and the analog
part of the HUB.

Fixes: 673655f7944f ("usb: misc: onboard_dev: add vdda support for Microchip USB2514")
Signed-off-by: Gabriel Fernandez <gabriel.fernandez@foss.st.com>
Signed-off-by: Fabrice Gasnier <fabrice.gasnier@foss.st.com>
---
 arch/arm/boot/dts/st/stm32mp157c-ev1.dts | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm/boot/dts/st/stm32mp157c-ev1.dts b/arch/arm/boot/dts/st/stm32mp157c-ev1.dts
index 0e65a1862eb5..ce014561a8ac 100644
--- a/arch/arm/boot/dts/st/stm32mp157c-ev1.dts
+++ b/arch/arm/boot/dts/st/stm32mp157c-ev1.dts
@@ -439,6 +439,7 @@ hub@1 {
 		compatible = "usb424,2514";
 		reg = <1>;
 		vdd-supply = <&v3v3>;
+		vdda-supply = <&v3v3>;
 	};
 };
 

-- 
2.43.0

[PATCH 3/3] ARM: dts: stm32: fix vdda supply for onboard hub on stm32mp135f-dk

[Fabrice Gasnier]

stm32mp135f-dk uses Microchip USB2514 HUB. Since vdda supply has been
added, the regulator framework wrongly associates the 'vdda' supply
dedicated to ADC, so the wrong regulator is referenced.
Only the 3v3 regulator is used to supply both the digital and the analog
part of the HUB.

Fixes: 673655f7944f ("usb: misc: onboard_dev: add vdda support for Microchip USB2514")
Signed-off-by: Gabriel Fernandez <gabriel.fernandez@foss.st.com>
Signed-off-by: Fabrice Gasnier <fabrice.gasnier@foss.st.com>
---
 arch/arm/boot/dts/st/stm32mp135f-dk.dts | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm/boot/dts/st/stm32mp135f-dk.dts b/arch/arm/boot/dts/st/stm32mp135f-dk.dts
index 6022e73f58af..5528b99ecf50 100644
--- a/arch/arm/boot/dts/st/stm32mp135f-dk.dts
+++ b/arch/arm/boot/dts/st/stm32mp135f-dk.dts
@@ -628,6 +628,7 @@ hub@1 {
 		compatible = "usb424,2514";
 		reg = <1>;
 		vdd-supply = <&scmi_v3v3_sw>;
+		vdda-supply = <&scmi_v3v3_sw>;
 	};
 };
 

-- 
2.43.0

Re: [PATCH 1/3] ARM: dts: stm32: fix vdda supply for onboard hub on stm32mp15 DK boards

[sashiko-bot]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [High] Adding `vdda-supply = <&v3v3>;` in the base DK dtsi causes a dangling regulator reference in the SCMI variant `stm32mp157f-dk2.dts`, leading to indefinite probe deferral of the USB hub.
--

--- Patch [1]: [PATCH 1/3] ARM: dts: stm32: fix vdda supply for onboard hub on stm32mp15 DK boards ---
commit 7026553f1e1e9967635ef09d235c6eb6bc13f81a
Author: Fabrice Gasnier <fabrice.gasnier@foss.st.com>

ARM: dts: stm32: fix vdda supply for onboard hub on stm32mp15 DK boards

This commit fixes the regulator association for the vdda supply on the
Microchip USB2514 HUB used on stm32mp15 DK boards. It sets the vdda-supply
to use the v3v3 regulator, as the 3.3V regulator supplies both the digital
and analog parts of the hub.

> diff --git a/arch/arm/boot/dts/st/stm32mp15xx-dkx.dtsi b/arch/arm/boot/dts/st/stm32mp15xx-dkx.dtsi
> index 599ea07bdb19c..01ac3d7d6d0ef 100644
> --- a/arch/arm/boot/dts/st/stm32mp15xx-dkx.dtsi
> +++ b/arch/arm/boot/dts/st/stm32mp15xx-dkx.dtsi
> @@ -764,6 +764,7 @@ hub@1 {
>  		compatible = "usb424,2514";
>  		reg = <1>;
>  		vdd-supply = <&v3v3>;
> +		vdda-supply = <&v3v3>;
[Severity: High]
Does adding this supply here without updating the SCMI variant cause probe
deferrals on stm32mp157f-dk2?

In arch/arm/boot/dts/st/stm32mp157f-dk2-scmi.dtsi, vdd-supply is overridden
to use the SCMI regulator, but vdda-supply is missed:

&usbh_ehci {
	hub@1 {
		vdd-supply = <&scmi_v3v3>;
	};
};

Will this cause vdda-supply to inherit <&v3v3>, which points to a disabled
node in stm32mp157f-dk2.dts, and result in the hub indefinitely failing to
probe?

>  	};
>  };

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260821-usb_fixes_vdda-v1-v1-0-0c213062165f@foss.st.com?part=1