* [PATCH v2 2/3] dt-bindings: iio: adc: rockchip-saradc: Group single-entries into an enum list
2026-08-23 12:20 [PATCH v2 0/3] Fix RV1106 SAR-ADC support Vladislav Leonov
@ 2026-08-23 12:20 ` Vladislav Leonov
2026-08-24 16:38 ` Conor Dooley
2026-08-23 12:20 ` [PATCH v2 3/3] dt-bindings: iio: adc: rockchip-saradc: Fix RV1106 compatible Vladislav Leonov
1 sibling, 1 reply; 5+ messages in thread
From: Vladislav Leonov @ 2026-08-23 12:20 UTC (permalink / raw)
To: Jonathan Cameron
Cc: Vladislav Leonov, David Lechner, Nuno Sá, Andy Shevchenko,
Rob Herring, Krzysztof Kozlowski, Conor Dooley, Heiko Stuebner,
Joshua Crofts, Simon Glass, linux-iio, devicetree,
linux-arm-kernel, linux-rockchip, linux-kernel,
Krzysztof Kozlowski
Group single-entries into an enum list
Suggested-by: Krzysztof Kozlowski <krzk@kernel.org>
Signed-off-by: Vladislav Leonov <vlad@zlab.su>
---
Changes in v2:
- Patch introduced in v2.
.../bindings/iio/adc/rockchip-saradc.yaml | 13 +++++++------
1 file changed, 7 insertions(+), 6 deletions(-)
diff --git a/Documentation/devicetree/bindings/iio/adc/rockchip-saradc.yaml b/Documentation/devicetree/bindings/iio/adc/rockchip-saradc.yaml
index f0551d665916..78ec9a33da24 100644
--- a/Documentation/devicetree/bindings/iio/adc/rockchip-saradc.yaml
+++ b/Documentation/devicetree/bindings/iio/adc/rockchip-saradc.yaml
@@ -12,15 +12,16 @@ maintainers:
properties:
compatible:
oneOf:
- - const: rockchip,saradc
- - const: rockchip,rk3066-tsadc
- - const: rockchip,rk3399-saradc
- - const: rockchip,rk3528-saradc
+ - enum:
+ - rockchip,saradc
+ - rockchip,rk3066-tsadc
+ - rockchip,rk3399-saradc
+ - rockchip,rk3528-saradc
+ - rockchip,rk3562-saradc
+ - rockchip,rk3588-saradc
- items:
- const: rockchip,rk3506-saradc
- const: rockchip,rk3528-saradc
- - const: rockchip,rk3562-saradc
- - const: rockchip,rk3588-saradc
- items:
- enum:
- rockchip,rk3576-saradc
--
2.47.3
^ permalink raw reply related [flat|nested] 5+ messages in thread* [PATCH v2 3/3] dt-bindings: iio: adc: rockchip-saradc: Fix RV1106 compatible
2026-08-23 12:20 [PATCH v2 0/3] Fix RV1106 SAR-ADC support Vladislav Leonov
2026-08-23 12:20 ` [PATCH v2 2/3] dt-bindings: iio: adc: rockchip-saradc: Group single-entries into an enum list Vladislav Leonov
@ 2026-08-23 12:20 ` Vladislav Leonov
2026-08-24 16:38 ` Conor Dooley
1 sibling, 1 reply; 5+ messages in thread
From: Vladislav Leonov @ 2026-08-23 12:20 UTC (permalink / raw)
To: Jonathan Cameron
Cc: Vladislav Leonov, David Lechner, Nuno Sá, Andy Shevchenko,
Rob Herring, Krzysztof Kozlowski, Conor Dooley, Heiko Stuebner,
Joshua Crofts, Simon Glass, linux-iio, devicetree,
linux-arm-kernel, linux-rockchip, linux-kernel
rockchip,rv1106-saradc was folded into the fallback enum together
with rockchip,rk3576-saradc, falling back to rockchip,rk3588-saradc.
The two IP blocks are not equivalent, though: per the RV1106 TRM v0.3,
chapter 20 (SAR-ADC), RV1106 only has 2 channels at 10-bit resolution,
versus 8 channels at 12-bit on RK3588. Documenting it as falling back
to rk3588-saradc allows device trees that would bind against the wrong
channel table and report an incorrect voltage scale.
Remove rockchip,rv1106-saradc from the RK3588 fallback enum and give
it its own standalone compatible entry, matching the dedicated match
table entry added by the driver patch.
Fixes: bdba14f6122c ("dt-bindings: iio: adc: rockchip-saradc: Add RV1106 compatible")
Suggested-by: Jonathan Cameron <jic23@kernel.org>
Signed-off-by: Vladislav Leonov <vlad@zlab.su>
---
Changes in v2:
- Added missing Suggested-by tag.
- rockchip,rv1106-saradc compatible moved from the single-entry to enum list.
v1 https://lore.kernel.org/all/20260816113636.33635-1-vlad@zlab.su
.../devicetree/bindings/iio/adc/rockchip-saradc.yaml | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/Documentation/devicetree/bindings/iio/adc/rockchip-saradc.yaml b/Documentation/devicetree/bindings/iio/adc/rockchip-saradc.yaml
index 78ec9a33da24..0cce357cb01d 100644
--- a/Documentation/devicetree/bindings/iio/adc/rockchip-saradc.yaml
+++ b/Documentation/devicetree/bindings/iio/adc/rockchip-saradc.yaml
@@ -19,13 +19,12 @@ properties:
- rockchip,rk3528-saradc
- rockchip,rk3562-saradc
- rockchip,rk3588-saradc
+ - rockchip,rv1106-saradc
- items:
- const: rockchip,rk3506-saradc
- const: rockchip,rk3528-saradc
- items:
- - enum:
- - rockchip,rk3576-saradc
- - rockchip,rv1106-saradc
+ - const: rockchip,rk3576-saradc
- const: rockchip,rk3588-saradc
- items:
- enum:
--
2.47.3
^ permalink raw reply related [flat|nested] 5+ messages in thread