From: sashiko-bot@kernel.org
To: Prabhakar <prabhakar.csengg@gmail.com>
Cc: conor+dt@kernel.org, wsa+renesas@sang-engineering.com,
robh@kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH 3/3] arm64: dts: renesas: rzt2h-n2h-evk: Enable RTC support
Date: Mon, 24 Aug 2026 08:08:15 +0000 [thread overview]
Message-ID: <20260824080816.2356E1F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260824075936.2904336-4-prabhakar.mahadev-lad.rj@bp.renesas.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The `rtc0` alias is inserted out of alphabetical order.
--
--- Patch [3]: [PATCH 3/3] arm64: dts: renesas: rzt2h-n2h-evk: Enable RTC support ---
commit 4c031325b18a88190b2540d40329c1e40cc8033e
Author: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
arm64: dts: renesas: rzt2h-n2h-evk: Enable RTC support
Enable RTC support on RZ/T2H and RZ/N2H EVKs.
> diff --git a/arch/arm64/boot/dts/renesas/rzt2h-n2h-evk-common.dtsi b/arch/arm64/boot/dts/renesas/rzt2h-n2h-evk-common.dtsi
> index e86e6d3aa8a34..add0718f98dcd 100644
> --- a/arch/arm64/boot/dts/renesas/rzt2h-n2h-evk-common.dtsi
> +++ b/arch/arm64/boot/dts/renesas/rzt2h-n2h-evk-common.dtsi
> @@ -21,6 +21,7 @@ aliases {
> mmc0 = &sdhi0;
> mmc1 = &sdhi1;
> serial0 = &sci0;
> + rtc0 = &rtc0;
[Severity: Low]
This isn't a bug, but should the rtc0 alias be placed before serial0 to
maintain strict alphabetical ordering in the aliases node?
> spi0 = &xspi0;
> spi1 = &xspi1;
> };
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260824075936.2904336-1-prabhakar.mahadev-lad.rj@bp.renesas.com?part=3
next prev parent reply other threads:[~2026-08-24 8:08 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-24 7:59 [PATCH 0/3] Enable RTC support on RZ/T2H and RZ/N2H SoCs Prabhakar
2026-08-24 7:59 ` [PATCH 1/3] arm64: dts: renesas: r9a09g077: Add RTC node Prabhakar
2026-08-24 8:13 ` sashiko-bot
2026-08-25 12:22 ` Geert Uytterhoeven
2026-08-24 7:59 ` [PATCH 2/3] arm64: dts: renesas: r9a09g087: " Prabhakar
2026-08-24 8:11 ` sashiko-bot
2026-08-25 12:22 ` Geert Uytterhoeven
2026-08-24 7:59 ` [PATCH 3/3] arm64: dts: renesas: rzt2h-n2h-evk: Enable RTC support Prabhakar
2026-08-24 8:08 ` sashiko-bot [this message]
2026-08-24 9:25 ` Wolfram Sang
2026-08-24 12:32 ` Geert Uytterhoeven
2026-08-24 9:30 ` Wolfram Sang
2026-08-25 12:23 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260824080816.2356E1F000E9@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=prabhakar.csengg@gmail.com \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox