Re: [PATCH 2/3] arm64: dts: renesas: r9a09g087: Add RTC node

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The macro `R9A09G087_PCLKRTC` used in the `clocks` property of the `rtc0` node is undefined, which will cause a Device Tree Compiler (dtc) syntax error.
--

--- Patch [2]: [PATCH 2/3] arm64: dts: renesas: r9a09g087: Add RTC node ---
commit 17edcdb9ccacc177ffc6dada7867d0b9b83bfdd5
Author: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>

arm64: dts: renesas: r9a09g087: Add RTC node

Add Real Time Clock (RTC) node to SoC DTSI.

> diff --git a/arch/arm64/boot/dts/renesas/r9a09g087.dtsi b/arch/arm64/boot/dts/renesas/r9a09g087.dtsi
> --- a/arch/arm64/boot/dts/renesas/r9a09g087.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r9a09g087.dtsi
[ ... ]
> @@ -1149,6 +1149,19 @@ pinctrl: pinctrl@802c0000 {
>  			power-domains = <&cpg>;
>  		};
>  
> +		rtc0: rtc@81009000 {
> +			compatible = "renesas,r9a09g087-rtc", "renesas,r9a09g077-rtc";
> +			reg = <0 0x81009000 0 0x1000>;
> +			interrupts = <GIC_SPI 495 IRQ_TYPE_EDGE_RISING>,
> +				     <GIC_SPI 497 IRQ_TYPE_EDGE_RISING>,
> +				     <GIC_SPI 496 IRQ_TYPE_EDGE_RISING>;
> +			interrupt-names = "alarm", "timer", "pps";
> +			clocks = <&cpg CPG_MOD 605>, <&cpg CPG_CORE R9A09G087_PCLKRTC>;

[Severity: Low]
Does this introduce a device tree compilation regression? It looks like the
macro R9A09G087_PCLKRTC used in the clocks property is undefined.

Since the preprocessor will leave an undefined macro as a literal string,
this will cause a syntax error when the device tree compiler attempts to
parse it as a numeric cell value. Was the definition for R9A09G087_PCLKRTC
perhaps left out of this patch series?

> +			clock-names = "hclk", "xtal";
> +			power-domains = <&cpg>;
> +			status = "disabled";
> +		};
> +
>  		gic: interrupt-controller@83000000 {
>  			compatible = "arm,gic-v3";
>  			reg = <0x0 0x83000000 0 0x40000>,

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260824075936.2904336-1-prabhakar.mahadev-lad.rj@bp.renesas.com?part=2