Re: [PATCH v6 3/4] arm64: dts: qcom: add basic devicetree for Ayaneo Pocket DS gaming console

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Medium] The PWM fan control pin is actively driven HIGH during system suspend while the fan's power supply is disabled, causing leakage current and potentially running the fan at 100% duty cycle if back-powered.
- [Low] PCIe child nodes have unit addresses that do not match the first address cell of their 'reg' property.
--

--- Patch [3]: [PATCH v6 3/4] arm64: dts: qcom: add basic devicetree for Ayaneo Pocket DS gaming console ---
commit 44774ff01d05ab46cbf94f40052649086f920bb4
Author: Teguh Sobirin <teguh@sobir.in>

arm64: dts: qcom: add basic devicetree for Ayaneo Pocket DS gaming console

Adds initial Device Tree for the Ayaneo Pocket DS gaming console based
on the QCS8550 platform, wiring up core peripherals, USB-C/DP, microSD, 
WiFi/BT, and gaming controls.

> diff --git a/arch/arm64/boot/dts/qcom/qcs8550-ayaneo-pocket-ds.dts b/arch/arm64/boot/dts/qcom/qcs8550-ayaneo-pocket-ds.dts
> new file mode 100644
> index 0000000000000..09b1c86cc3d35
> --- /dev/null
> +++ b/arch/arm64/boot/dts/qcom/qcs8550-ayaneo-pocket-ds.dts

[ ... ]

> +	vdd_fan_5v0: vdd-fan-5v0-regulator {
> +		compatible = "regulator-fixed";
> +
> +		regulator-name = "vdd_fan_5v0";
> +		regulator-min-microvolt = <5000000>;
> +		regulator-max-microvolt = <5000000>;
> +
> +		gpios = <&tlmm 31 GPIO_ACTIVE_HIGH>;
> +		enable-active-high;
> +
> +		pinctrl-0 = <&fan_pwr_active>;
> +		pinctrl-names = "default";
> +
> +		regulator-state-mem {
> +			regulator-off-in-suspend;
> +		};
> +	};

[ ... ]

> +&pm8550_gpios {

[ ... ]

> +	fan_pwm_sleep: fan-pwm-sleep-state {
> +		pins = "gpio9";
> +		function = "normal";
> +		output-high;

[Severity: Medium]
Does driving this pin high during suspend create a leakage path? Since
vdd_fan_5v0 is configured with regulator-off-in-suspend, actively driving
the control pin into an unpowered fan controller might cause back-powering.

> +		bias-disable;
> +		power-source = <0>;
> +		qcom,drive-strength = <3>; /* PMIC_GPIO_STRENGTH_LOW */
> +	};

[ ... ]

> +&pcie0_port0 {
> +	wifi@0 {
> +		compatible = "pci17cb,1107";
> +		reg = <0x10000 0x0 0x0 0x0 0x0>;

[Severity: Low]
Should the node name match the unit address in the reg property? It looks
like this should be wifi@10000 to avoid dtc validation warnings.

> +
> +		vddrfacmn-supply = <&vreg_pmu_rfa_cmn>;
> +		vddaon-supply = <&vreg_pmu_aon_0p59>;

[ ... ]

> +&pcie1_port0 {
> +	/* Renesas μPD720201 PCIe USB3.0 HOST CONTROLLER */
> +	usb-controller@0 {
> +		compatible = "pci1912,0014";
> +		reg = <0x10000 0x0 0x0 0x0 0x0>;

[Severity: Low]
Should this node also be named usb-controller@10000 to match the first
address cell in the reg property?

> +
> +		avdd33-supply = <&upd720201_avdd33_reg>;
> +		vdd10-supply = <&upd720201_vdd10_reg>;

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260824-pocketds-v6-0-370161574ca2@gmail.com?part=3