Devicetree
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: pankaj.gupta@oss.nxp.com
Cc: imx@lists.linux.dev, Frank.Li@kernel.org, conor+dt@kernel.org,
	devicetree@vger.kernel.org, robh@kernel.org
Subject: Re: [PATCH v42 2/7] dt-bindings: arm: fsl: add imx-se-fw binding doc
Date: Mon, 24 Aug 2026 17:44:17 +0000	[thread overview]
Message-ID: <20260824174417.C33451F00A3A@smtp.kernel.org> (raw)
In-Reply-To: <20260825-imx-se-if-v42-2-2e8efac0bb16@nxp.com>

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Direct contradiction between the architectural documentation for the i.MX95 Secure Enclave and the implemented device tree binding schema.
--

--- Patch [2]: [PATCH v42 2/7] dt-bindings: arm: fsl: add imx-se-fw binding doc ---
commit a9570710d7ea386acbf5fca1ead47f270b0bbd1e
Author: Pankaj Gupta <pankaj.gupta@nxp.com>

dt-bindings: arm: fsl: add imx-se-fw binding doc

This patch introduces the device tree binding documentation for NXP i.MX
Secure Enclave hardware. It specifies the compatible strings and properties
needed for communication between the application core and enclave firmware
via a mailbox interface.

> diff --git a/Documentation/devicetree/bindings/firmware/fsl,imx-se.yaml b/Documentation/devicetree/bindings/firmware/fsl,imx-se.yaml
> new file mode 100644
> index 0000000000000..fa81adbf9b80d
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/firmware/fsl,imx-se.yaml

[ ... ]

> +properties:
> +  compatible:
> +    enum:
> +      - fsl,imx8ulp-se-ele-hsm
> +      - fsl,imx93-se-ele-hsm
> +      - fsl,imx95-se-ele-hsm
[Severity: Low]
Does this compatible string contradict the architectural documentation?

Looking at Documentation/driver-api/firmware/other_interfaces.rst, it
states that i.MX95 secure enclaves will use a single unified compatible
node (fsl,imx95-se) for all enclaves.

By defining fsl,imx95-se-ele-hsm here instead of fsl,imx95-se, could this
create an inconsistency with the documented interface?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260825-imx-se-if-v42-0-2e8efac0bb16@nxp.com?part=2

  reply	other threads:[~2026-08-24 17:44 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-24 23:03 [PATCH v42 0/7] firmware: imx: driver for NXP secure-enclave pankaj.gupta
2026-08-24 23:03 ` [PATCH v42 1/7] Documentation/firmware: add imx/se to other_interfaces pankaj.gupta
2026-08-24 23:03 ` [PATCH v42 2/7] dt-bindings: arm: fsl: add imx-se-fw binding doc pankaj.gupta
2026-08-24 17:44   ` sashiko-bot [this message]
2026-08-24 23:03 ` [PATCH v42 3/7] firmware: imx: add driver for NXP EdgeLock Enclave pankaj.gupta
2026-08-24 17:45   ` sashiko-bot
2026-08-24 23:03 ` [PATCH v42 4/7] firmware: imx: device context dedicated to priv pankaj.gupta
2026-08-24 23:03 ` [PATCH v42 5/7] firmware: imx: adds miscdev pankaj.gupta
2026-08-24 17:50   ` sashiko-bot
2026-08-25 15:06     ` Frank Li
2026-08-25 15:28   ` Frank Li
2026-08-24 23:03 ` [PATCH v42 6/7] arm64: dts: imx8ulp: add secure enclave node pankaj.gupta
2026-08-24 23:03 ` [PATCH v42 7/7] arm64: dts: imx8ulp: add reserved memory for EdgeLock Enclave pankaj.gupta

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260824174417.C33451F00A3A@smtp.kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=Frank.Li@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=imx@lists.linux.dev \
    --cc=pankaj.gupta@oss.nxp.com \
    --cc=robh@kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox