From: sashiko-bot@kernel.org
To: "Marek Vasut" <marex@nabladev.com>
Cc: conor+dt@kernel.org, imx@lists.linux.dev, robh@kernel.org,
Frank.Li@kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH] arm64: dts: imx8mn: Add ifm VHIP4 EvalBoard configuration EEPROM layout DTOs
Date: Tue, 25 Aug 2026 14:02:50 +0000 [thread overview]
Message-ID: <20260825140251.28B981F00A3A@smtp.kernel.org> (raw)
In-Reply-To: <20260825135754.864501-1-marex@nabladev.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The device tree node for the software compatibility field is misspelled as 'software-comatibility' (missing 'p'). As these fields are exposed via the sysfs nvmem interface, this typo will become a permanent userspace ABI.
--
--- Patch [1]: [PATCH] arm64: dts: imx8mn: Add ifm VHIP4 EvalBoard configuration EEPROM layout DTOs ---
commit a29716c722da3485b2bb345e32239ee52540c286
Author: Marek Vasut <marex@nabladev.com>
arm64: dts: imx8mn: Add ifm VHIP4 EvalBoard configuration EEPROM layout DTOs
Add DT overlays which describe configuration EEPROM VHIP section,
for VHIP section v1.0.0.0, v1.1.0.0, v2.0.0.0, used on ifm VHIP4
EvalBoard. With the DTO applied, the VHIP section fields become
accessible via the sysfs nvmem interface.
> diff --git a/arch/arm64/boot/dts/freescale/imx8mn-vhip4-overlay-eeprom-1000.dtso b/arch/arm64/boot/dts/freescale/imx8mn-vhip4-overlay-eeprom-1000.dtso
> new file mode 100644
> index 0000000000000..41641c54164f1
> --- /dev/null
> +++ b/arch/arm64/boot/dts/freescale/imx8mn-vhip4-overlay-eeprom-1000.dtso
[ ... ]
> + product-type@64 {
> + reg = <0x64 0x20>;
> + };
> +
> + software-comatibility@84 {
[Severity: Medium]
Is there a typo in this node name? It appears to be missing a 'p' and should
perhaps be software-compatibility@84.
> + reg = <0x84 0x4>;
> + };
> +
> + manufacturing-date@88 {
[ ... ]
> diff --git a/arch/arm64/boot/dts/freescale/imx8mn-vhip4-overlay-eeprom-1100.dtso b/arch/arm64/boot/dts/freescale/imx8mn-vhip4-overlay-eeprom-1100.dtso
> new file mode 100644
> index 0000000000000..5f89b1af6874d
> --- /dev/null
> +++ b/arch/arm64/boot/dts/freescale/imx8mn-vhip4-overlay-eeprom-1100.dtso
[ ... ]
> + product-type@84 {
> + reg = <0x84 0x20>;
> + };
> +
> + software-comatibility@a4 {
[Severity: Medium]
Does this node name also contain the same missing 'p' typo?
> + reg = <0xa4 0x4>;
> + };
> +
> + manufacturing-date@a8 {
[ ... ]
> diff --git a/arch/arm64/boot/dts/freescale/imx8mn-vhip4-overlay-eeprom-2000.dtso b/arch/arm64/boot/dts/freescale/imx8mn-vhip4-overlay-eeprom-2000.dtso
> new file mode 100644
> index 0000000000000..01599bf46ac18
> --- /dev/null
> +++ b/arch/arm64/boot/dts/freescale/imx8mn-vhip4-overlay-eeprom-2000.dtso
[ ... ]
> + product-type@90 {
> + reg = <0x90 0x20>;
> + };
> +
> + software-comatibility@b0 {
[Severity: Medium]
Could this node name be corrected to software-compatibility as well?
> + reg = <0xb0 0x4>;
> + };
> +
> + manufacturing-date@b4 {
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260825135754.864501-1-marex@nabladev.com?part=1
next prev parent reply other threads:[~2026-08-25 14:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-25 13:57 [PATCH] arm64: dts: imx8mn: Add ifm VHIP4 EvalBoard configuration EEPROM layout DTOs Marek Vasut
2026-08-25 14:02 ` sashiko-bot [this message]
2026-08-25 14:17 ` Frank Li
2026-08-25 14:27 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260825140251.28B981F00A3A@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=Frank.Li@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=imx@lists.linux.dev \
--cc=marex@nabladev.com \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox