Re: [PATCH v4 16/19] crypto: cmh - add SLH-DSA/LMS/XMSS (HCQ)

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Mixed declarations and code violate strict declaration-after-statement coding style
--

commit 0ef415a044191dc8d92f6871f0f86042ccf5c94f
Author: Alex Ousherovitch <aousherovitch@rambus.com>

crypto: cmh - add SLH-DSA/LMS/XMSS (HCQ)

This commit registers SLH-DSA, LMS, LMS-HSS, XMSS, and XMSS-MT algorithms
using the CMH HCQ core. SLH-DSA is registered with sign and verify support,
while the others are exposed as verify-only algorithms since their stateful
semantics are not modeled by the kernel crypto API.

> diff --git a/drivers/crypto/cmh/cmh_pqc_slhdsa.c b/drivers/crypto/cmh/cmh_pqc_slhdsa.c
> new file mode 100644
> --- /dev/null
> +++ b/drivers/crypto/cmh/cmh_pqc_slhdsa.c
[ ... ]
> +static int cmh_slhdsa_sign(struct crypto_sig *tfm,
> +			   const void *src, unsigned int slen,
> +			   void *dst, unsigned int dlen)
> +{
[ ... ]
> +	m_dma = cmh_dma_map_single(m_buf, slen, DMA_TO_DEVICE);
> +	sig_dma = cmh_dma_map_single(sig_buf, sig_sz, DMA_FROM_DEVICE);
> +	if (cmh_dma_map_error(m_dma) || cmh_dma_map_error(sig_dma)) {
> +		ret = -ENOMEM;
> +		goto out_unmap;
> +	}
> +
> +	sk_dma = DMA_MAPPING_ERROR;
> +	idx = 0;
> +
> +	struct core_dispatch d;

[Severity: Low]
This isn't a bug, but could this variable declaration be moved to the start
of the block? The kernel coding style historically expects variables to be
declared before executable statements. Mixing declarations and code here can
trigger warnings on older toolchains or depending on subsystem Makefile flags.

> +
> +	d = cmh_core_select_instance(CMH_CORE_HCQ);
[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260825221539.255951-1-aousherovitch@rambus.com?part=16