Re: [PATCH v4 03/10] dtc: dt-check-style: Fix alignment of values in continued property lines

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Trailing whitespace or comments break multi-line property alignment validation.
--

commit aff0e119d6465ed21424e22c5bbba8149c80bcf4
Author: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>

dtc: dt-check-style: Fix alignment of values in continued property lines

This commit updates the device tree style checker to properly enforce
alignment rules for continued property lines. It adds logic to ensure inner
values inside phandles or strings are aligned correctly based on the
previous line's completion status.

> diff --git a/scripts/dtc/dt-check-style b/scripts/dtc/dt-check-style
> index 833f8a03ddc9b..486dd1d6bb9a7 100755
> --- a/scripts/dtc/dt-check-style
> +++ b/scripts/dtc/dt-check-style
[ ... ]
> @@ -940,15 +941,23 @@ def check_continuation_alignment(ctx):
>              continue
>          # First '<' or '"' after '='
>          rest = dl.raw[eq + 1:]
> -        m = re.search(r'[<"]', rest)
> +        m = re.search(r'\s*([<"])', rest)
>          if not m:
>              continue
> -        target_col = _display_col(dl.raw[:eq + 1 + m.start()])
> +        dl_value_complete = rest.endswith('",') or rest.endswith('>,')

[Severity: Low]
Does this evaluation properly handle trailing inline comments or whitespace?

If the rest string retains trailing characters like inline comments 
(e.g. >, /* foo */) or unexpected whitespace, endswith() will return false 
even if the value is complete. This could cause the script to incorrectly 
conclude the property is incomplete and mandate an incorrect indentation 
for the continuation line.

> +        target_col = _display_col(dl.raw[:eq + 1 + m.start(1)])
>          for cont in dl.continuations:
> -            if _display_col(cont.indent_str) != target_col:
> +            target_offset = 0
> +            err_msg_explanation = 'to < or "'
> +            if not dl_value_complete:
> +                target_offset = 1
> +                err_msg_explanation = 'to the value under <'
> +            if _display_col(cont.indent_str) != target_col + target_offset:
>                  yield (cont.lineno,
>                         'continuation should align to column %d '
> -                       '(under < or ")' % (target_col + 1))
> +                       '(%s)' % (target_col + target_offset + 1, err_msg_explanation))
> +            # Align to the value within <> or "" of continuation (so the previous line)
> +            dl_value_complete = cont.stripped.endswith('",') or cont.stripped.endswith('>,')

[Severity: Low]
Can this cause false positives for chained continuation lines?

Similarly to the rest variable above, if cont.stripped retains trailing
comments, endswith() will evaluate to false. Could this result in the same
false-positive warnings when checking the next continuation line?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260826-n-dts-style-checker-continued-v4-0-022e60091965@oss.qualcomm.com?part=3