From: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
To: sashiko-reviews@lists.linux.dev
Cc: robh@kernel.org, conor+dt@kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v4 09/10] dtc: dt-check-style: Add warning for redundant white-spaces
Date: Wed, 26 Aug 2026 10:56:39 +0200 [thread overview]
Message-ID: <bce242d1-de57-444a-a1b6-93a941372f01@oss.qualcomm.com> (raw)
In-Reply-To: <20260826071827.867DF1F000E9@smtp.kernel.org>
On 26/08/2026 09:18, sashiko-bot@kernel.org wrote:
> Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
> - [High] The regular expression `r'(\s\s+|\t){'` uses an unescaped `{` character immediately after a capturing group. In Python 3.11+, the `re` module enforces strict parsing and treats this as a malformed repetition operator, raising `re.error`. This unconditionally crashes the `dt-check-style` script upon execution.
Ack
> - [Low] The redundant whitespace checks do not validate continuation lines of multi-line properties, causing them to silently miss styling violations.
Ack
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-08-26 8:56 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-26 7:05 [PATCH v4 00/10] dtc: dt-check-style: Improvements for false positives Krzysztof Kozlowski
2026-08-26 7:05 ` [PATCH v4 01/10] dtc: dt-check-style: Handle sorting of top-level nodes and properties Krzysztof Kozlowski
2026-08-26 7:05 ` [PATCH v4 02/10] dtc: dt-check-style: Drop stray backslash before quote for continuation-alignment Krzysztof Kozlowski
2026-08-26 7:05 ` [PATCH v4 03/10] dtc: dt-check-style: Fix alignment of values in continued property lines Krzysztof Kozlowski
2026-08-26 7:13 ` sashiko-bot
2026-08-26 10:00 ` Krzysztof Kozlowski
2026-08-26 7:05 ` [PATCH v4 04/10] dtc: dt-check-style: Consistently call 'kind' as 'file_type' Krzysztof Kozlowski
2026-08-26 7:05 ` [PATCH v4 05/10] dtc: dt-check-style: Introduce 'stricter' mode Krzysztof Kozlowski
2026-08-26 7:05 ` [PATCH v4 06/10] dtc: dt-check-style: Replace Test User email with Rob Herring Krzysztof Kozlowski
2026-08-26 7:06 ` [PATCH v4 07/10] dtc: dt-check-style: Call _strip_strings_and_comments() only once Krzysztof Kozlowski
2026-08-26 7:06 ` [PATCH v4 08/10] dtc: dt-check-style: Add test for trailing white-space in DTS Krzysztof Kozlowski
2026-08-26 7:06 ` [PATCH v4 09/10] dtc: dt-check-style: Add warning for redundant white-spaces Krzysztof Kozlowski
2026-08-26 7:18 ` sashiko-bot
2026-08-26 8:56 ` Krzysztof Kozlowski [this message]
2026-08-26 7:06 ` [PATCH v4 10/10] MAINTAINERS: dt-bindings: Include dt-check-style in DT binding entry Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bce242d1-de57-444a-a1b6-93a941372f01@oss.qualcomm.com \
--to=krzysztof.kozlowski@oss.qualcomm.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox