Re: [PATCH 06/10] dt-bindings: ufs: Add compatibles for S32N79 Host Controller platform driver

[Krzysztof Kozlowski <krzk@kernel.org>]

On Wed, Aug 26, 2026 at 03:40:44PM +0200, Larisa Grigore wrote:
> +  clocks:
> +    maxItems: 1
> +    description: UFS core clock
> +
> +  clock-names:
> +    items:
> +      - const: core_clk

_clk is redundant, just "core". Or skip names, not really useful in this
case.

> +
> +  nxp,mphy-boot-mode:
> +    description: |
> +      MPHY initialization mode. Defines how the MPHY firmware should be
> +      initialized and executed during UFS controller startup.
> +      If this property is not specified, MPHY initialization will be skipped.

Isn't this implied by the compatible?

> +    $ref: /schemas/types.yaml#/definitions/string
> +    enum:
> +      - rom
> +
> +required:
> +  - compatible
> +  - reg
> +
> +allOf:
> +  - $ref: ufs-common.yaml
> +  - if:
> +      required:
> +        - nxp,mphy-boot-mode
> +    then:
> +      properties:
> +        reg:
> +          minItems: 2
> +        reg-names:
> +          minItems: 2
> +      required:
> +        - reg-names
> +        - clocks
> +        - clock-names
> +    else:
> +      properties:
> +        reg:
> +          maxItems: 1
> +        reg-names:
> +          maxItems: 1

I don't get why for the SAME device diffeernt initialization means
device has different address space or clocks. It's the same device, same
wiring, same hardware setup.

Best regards,
Krzysztof