Re: [PATCH RFC/DO NOT MERGE 06/12] dt-bindings: display/msm: eliza-hdmi-phy: Add Eliza HDMI PHY

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Devicetree unit address mismatch in schema example.
--

commit 2063c7e805b5b72143440af38f64d666c647dad5
Author: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>

dt-bindings: display/msm: eliza-hdmi-phy: Add Eliza HDMI PHY

This commit adds the device tree binding for the Synopsys HDMI PHY found on
the Qualcomm Eliza SoC. It documents the required properties and provides an
example device node.

> diff --git a/Documentation/devicetree/bindings/phy/qcom,eliza-hdmi-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,eliza-hdmi-phy.yaml
> new file mode 100644
> index 0000000000000..764fec0ef29bf
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/phy/qcom,eliza-hdmi-phy.yaml

[ ... ]

> +examples:
> +  - |
> +    #include <dt-bindings/clock/qcom,eliza-dispcc.h>
> +    #include <dt-bindings/clock/qcom,eliza-tcsr.h>
> +    #include <dt-bindings/power/qcom,rpmhpd.h>
> +
> +    hdmi-phy@9a0600 {
> +        compatible = "qcom,eliza-hdmi-phy";
> +        reg = <0x0aea1000 0x1000>;

[Severity: Low]
Does this unit address in the node name mismatch the first address in the
reg property?

Running make dt_binding_check will likely trigger a unit_address_vs_reg
warning regression because the node is named hdmi-phy@9a0600 but its reg
property sets the base address to 0x0aea1000.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260828-drm-msm-hdmi-eliza-v1-0-67843277de17@oss.qualcomm.com?part=6