Re: [PATCH v4 1/4] iio: ABI: Add DAC current powerdown attributes and 15kohm_to_gnd mode

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Missing ABI documentation for `out_currentY_powerdown_mode_available` and `out_current_powerdown_mode_available` attributes.
--

commit 68e36d76df12ffaaa85169b7c722c98c67e19f8d
Author: Kim Seer Paller <kimseer.paller@analog.com>

iio: ABI: Add DAC current powerdown attributes and 15kohm_to_gnd mode

This commit updates the IIO ABI documentation to cover the
out_currentY_powerdown and out_currentY_powerdown_mode attributes. It also
introduces a new 15kohm_to_gnd powerdown mode.

> diff --git a/Documentation/ABI/testing/sysfs-bus-iio b/Documentation/ABI/testing/sysfs-bus-iio
> index a4f5595722ade..a0f9aada5c62d 100644
> --- a/Documentation/ABI/testing/sysfs-bus-iio
> +++ b/Documentation/ABI/testing/sysfs-bus-iio
> @@ -762,6 +762,8 @@ What:		/sys/bus/iio/devices/iio:deviceX/out_voltageY_powerdown_mode
>  What:		/sys/bus/iio/devices/iio:deviceX/out_voltage_powerdown_mode
>  What:		/sys/bus/iio/devices/iio:deviceX/out_altvoltageY_powerdown_mode
>  What:		/sys/bus/iio/devices/iio:deviceX/out_altvoltage_powerdown_mode
> +What:		/sys/bus/iio/devices/iio:deviceX/out_currentY_powerdown_mode
> +What:		/sys/bus/iio/devices/iio:deviceX/out_current_powerdown_mode
>  KernelVersion:	2.6.38
>  Contact:	linux-iio@vger.kernel.org
>  Description:

[Severity: Low]
Are the out_currentY_powerdown_mode_available and
out_current_powerdown_mode_available attributes missing from the
documentation?

Looking further down in Documentation/ABI/testing/sysfs-bus-iio, the voltage
and altvoltage variants have their _available attributes explicitly documented:

What:		/sys/.../iio:deviceX/out_voltageY_powerdown_mode_available
What:		/sys/.../iio:deviceX/out_voltage_powerdown_mode_available
What:		/sys/.../iio:deviceX/out_altvoltageY_powerdown_mode_available
What:		/sys/.../iio:deviceX/out_altvoltage_powerdown_mode_available

Would it make sense to document the current variants alongside these? Without
them, the documentation is incomplete for the _available attributes that the
IIO core automatically exposes for enum extensions.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260829-iio-ad5710r-upstream-v4-0-8af3121c7d21@analog.com?part=1