Re: [PATCH v4 2/4] dt-bindings: iio: dac: add adi,ad5710r.yaml

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The device tree example and schema documentation incorrectly require and include a header from an unrelated device (`adi,ad74413r.h`) to configure the AD5710R's channel functions.
--

commit 3746051355b5551010e58f435b49ff4409ec4699
Author: Kim Seer Paller <kimseer.paller@analog.com>

dt-bindings: iio: dac: add adi,ad5710r.yaml

This commit introduces device tree bindings for the Analog Devices
AD5710R/AD5711R DACs. It defines properties for power supplies, SPI
configuration, and per-channel output types.

> diff --git a/Documentation/devicetree/bindings/iio/dac/adi,ad5710r.yaml b/Documentation/devicetree/bindings/iio/dac/adi,ad5710r.yaml
> new file mode 100644
> index 0000000000000..259866ca87cff
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/dac/adi,ad5710r.yaml
[ ... ]
> +      adi,ch-func:
> +        description:
> +          Channel output type. Use CH_FUNC_VOLTAGE_OUTPUT for voltage
> +          output or CH_FUNC_CURRENT_OUTPUT for current output.

[Severity: Low]
Does this documentation suggest macros that don't exist for this specific 
device? It seems these macros are not provided in any device-specific 
header for the AD5710R, which might confuse users trying to configure the 
channel output type.

> +        $ref: /schemas/types.yaml#/definitions/uint32
> +        enum: [1, 2]
[ ... ]
> +examples:
> +  - |
> +    #include <dt-bindings/iio/addac/adi,ad74413r.h>

[Severity: Low]
Is this include directive for an unrelated device intentional here?

Including a device-specific header for an entirely different component 
creates an illogical dependency. This masks the missing macro definitions 
mentioned above by coupling the configuration to an inappropriate source. 

Could this break or cause confusion if the ad74413r bindings are ever 
refactored?

> +
> +    spi {
> +        #address-cells = <1>;

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260829-iio-ad5710r-upstream-v4-0-8af3121c7d21@analog.com?part=2