From: sashiko-bot@kernel.org
To: "Aleksei Sviridkin" <f@lex.la>
Cc: robh@kernel.org, devicetree@vger.kernel.org, conor+dt@kernel.org
Subject: Re: [RFC PATCH net-next 2/9] dt-bindings: net: ethernet-controller: add slow-to-probe
Date: Sun, 30 Aug 2026 05:26:21 +0000 [thread overview]
Message-ID: <20260830052621.9EA601F00A3D@smtp.kernel.org> (raw)
In-Reply-To: <20260829052546.1152446-3-f@lex.la>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The `slow-to-probe` property describes OS/software behavior (driver loading and boot sequencing) instead of hardware, and lacks an OS-specific prefix.
--
commit f5e8127fdbf6369101e1a77cf0e55acf75f7b643
Author: Aleksei Sviridkin <f@lex.la>
dt-bindings: net: ethernet-controller: add slow-to-probe
This commit adds a slow-to-probe property to the ethernet controller binding.
It allows a port to keep a PHY reference and attach to it later if the driver
or firmware is unavailable during the initial probe.
> diff --git a/Documentation/devicetree/bindings/net/ethernet-controller.yaml b/Documentation/devicetree/bindings/net/ethernet-controller.yaml
> index 1bafd687dcb18..ca82672b6cb38 100644
> --- a/Documentation/devicetree/bindings/net/ethernet-controller.yaml
> +++ b/Documentation/devicetree/bindings/net/ethernet-controller.yaml
> @@ -113,6 +113,15 @@ properties:
> description:
> Specifies a reference to a node representing an IEEE 1588 PTP device.
>
> + slow-to-probe:
> + $ref: /schemas/types.yaml#/definitions/flag
> + description:
> + The PHY referenced by phy-handle may not exist, or may not have a
> + usable driver, when this controller connects to it, because the
> + driver or firmware arrives later (for example from a filesystem
> + mounted after the controller probed). Instead of failing, keep
> + the port and connect the PHY once it becomes usable.
[Severity: Medium]
Does this property describe OS-specific software behavior rather than a
hardware configuration?
Since this flag addresses driver loading and boot sequencing (software
state), could it pollute the generic hardware Device Tree ABI by lacking
an OS-specific prefix like linux,?
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260829052546.1152446-1-f@lex.la?part=2
next prev parent reply other threads:[~2026-08-30 5:26 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-29 5:25 [RFC PATCH net-next 0/9] net: survive a PHY whose firmware arrives after the MAC probes Aleksei Sviridkin
2026-08-29 5:25 ` [RFC PATCH net-next 1/9] dt-bindings: net: add Airoha EN8811H PHY MCU Aleksei Sviridkin
2026-08-29 5:25 ` [RFC PATCH net-next 2/9] dt-bindings: net: ethernet-controller: add slow-to-probe Aleksei Sviridkin
2026-08-30 5:26 ` sashiko-bot [this message]
2026-09-04 0:29 ` Andrew Lunn
2026-08-29 5:25 ` [RFC PATCH net-next 3/9] net: phy: air: type the buckpbus core on the bus and address Aleksei Sviridkin
2026-09-04 0:48 ` Andrew Lunn
2026-08-29 5:25 ` [RFC PATCH net-next 4/9] net: phy: air: move the EN8811H firmware download into the library Aleksei Sviridkin
2026-09-04 1:16 ` Andrew Lunn
2026-08-29 5:25 ` [RFC PATCH net-next 5/9] net: phy: air: skip the download when the MD32 is already running Aleksei Sviridkin
2026-08-29 5:25 ` [RFC PATCH net-next 6/9] net: mdio: add Airoha EN8811H MDIO device driver Aleksei Sviridkin
2026-08-30 5:26 ` sashiko-bot
2026-09-04 1:36 ` Andrew Lunn
2026-08-29 5:25 ` [RFC PATCH net-next 7/9] net: mdio: en8811h: add the nested pass-through bus Aleksei Sviridkin
2026-09-04 1:43 ` Andrew Lunn
2026-08-29 5:25 ` [RFC PATCH net-next 8/9] net: phylink: wait for PHYs that are known to probe late Aleksei Sviridkin
2026-08-30 5:26 ` sashiko-bot
2026-08-29 5:25 ` [RFC PATCH net-next 9/9] net: phylink: report no link modes while a late PHY is missing Aleksei Sviridkin
2026-08-30 5:26 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260830052621.9EA601F00A3D@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=f@lex.la \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox