Re: [PATCH 10/13] regulator: ab8500: Preserve OTP-enabled buck regulators

[sashiko-bot@kernel.org]

> The SMPS enable fields are initialized from OTP and may leave a rail
> enabled for discrete consumers which cannot be described in the device
> tree. Such a rail currently looks unused to the regulator core and is
> disabled when constraints are completed.
> 
> Read the enable field while registering each switchable buck
> regulator. If it is nonzero, mark the regulator boot-on and always-on
> dynamically so the unused-regulator sweep leaves it alone. Keep the
> enable operation idempotent so applying the always-on constraint
> preserves an OTP-selected hardware-control or low-power mode instead of
> forcing high-power mode. Synchronize the cached mode with the preserved
> field so an OTP-selected low-power state is also reported correctly.
> 
> Regulators which are disabled by OTP retain normal switchable
> behavior.
> 
> Assisted-by: LLM
> Signed-off-by: Linus Walleij <linusw@kernel.org>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260831-ux500-dts-snowball-regulator-v1-0-fe279fff5e18@kernel.org?part=10