From: sashiko-bot@kernel.org
To: "Linus Walleij" <linusw@kernel.org>
Cc: devicetree@vger.kernel.org, mfd@lists.linux.dev, robh@kernel.org,
conor+dt@kernel.org, lee@kernel.org
Subject: Re: [PATCH 05/13] regulator: ab8500: Test dedicated enable bits only
Date: Sun, 30 Aug 2026 22:51:38 +0000 [thread overview]
Message-ID: <20260830225138.A31EB1F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260831-ux500-dts-snowball-regulator-v1-5-fe279fff5e18@kernel.org>
> Some regulator control registers have independent enable and low-power
> bits. is_enabled() currently tests their combined update mask, so an
> off regulator with its low-power bit set is incorrectly reported as
> enabled.
>
> Add an optional enable mask and use it for VINTCORE, AB8500 TVOUT,
> AB8505 ADC, and AB8505 VAUX5/6. Regulators whose two-bit field encodes
> the complete operating state continue to test the full update mask.
>
> References: AB8500 User Manual, UM0836 Rev 3, p. 214;
> AB8505 User Manual, DM00046744 Rev 3, pp. 171-172 and 223
>
> Fixes: 65e03ed2d0cd ("regulators: Fixed errors in ab8500 register mapping")
> Assisted-by: LLM
> Signed-off-by: Linus Walleij <linusw@kernel.org>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260831-ux500-dts-snowball-regulator-v1-0-fe279fff5e18@kernel.org?part=5
next prev parent reply other threads:[~2026-08-30 22:51 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-30 22:43 [PATCH 00/13] Add AB8500 buck regulators to the Ux500 device tree Linus Walleij
2026-08-30 22:43 ` [PATCH 01/13] regulator: ab8500: Fix AB8505 VANA voltage selectors Linus Walleij
2026-08-30 22:51 ` sashiko-bot
2026-08-30 22:43 ` [PATCH 02/13] regulator: ab8500: Add AB8505 VAUX3 3.05 V setting Linus Walleij
2026-08-30 22:49 ` sashiko-bot
2026-08-30 22:43 ` [PATCH 03/13] regulator: ab8500: Handle AB8505 VINTCORE selector 7 Linus Walleij
2026-08-30 22:51 ` sashiko-bot
2026-08-30 22:43 ` [PATCH 04/13] regulator: ab8500: Treat cut 1.0 VAUX3 as fixed Linus Walleij
2026-08-30 22:51 ` sashiko-bot
2026-08-30 22:43 ` [PATCH 05/13] regulator: ab8500: Test dedicated enable bits only Linus Walleij
2026-08-30 22:51 ` sashiko-bot [this message]
2026-08-30 22:43 ` [PATCH 06/13] regulator: ab8500: Propagate mode enable read errors Linus Walleij
2026-08-30 22:51 ` sashiko-bot
2026-08-30 22:43 ` [PATCH 07/13] regulator: ab8500: Use linear ranges for LDO voltages Linus Walleij
2026-08-30 22:52 ` sashiko-bot
2026-08-30 22:43 ` [PATCH 08/13] dt-bindings: mfd: ab8500: Add regulators Linus Walleij
2026-08-30 22:50 ` sashiko-bot
2026-08-31 16:18 ` Conor Dooley
2026-08-31 20:18 ` Linus Walleij
2026-09-01 17:58 ` Conor Dooley
2026-09-01 19:32 ` Linus Walleij
2026-08-30 22:43 ` [PATCH 09/13] regulator: ab8500: Add buck converter support Linus Walleij
2026-08-30 22:50 ` sashiko-bot
2026-08-30 22:43 ` [PATCH 10/13] regulator: ab8500: Preserve OTP-enabled buck regulators Linus Walleij
2026-08-30 22:50 ` sashiko-bot
2026-08-30 22:43 ` [PATCH 11/13] regulator: ab8500: Use scoped guard for shared mode mutex Linus Walleij
2026-08-30 22:56 ` sashiko-bot
2026-08-30 22:43 ` [PATCH 12/13] ARM: dts: ux500: Add new AB8500/AB8505 regulators Linus Walleij
2026-08-30 22:53 ` sashiko-bot
2026-08-30 22:43 ` [PATCH 13/13] ARM: dts: ux500: Fix up regulator assignments Linus Walleij
2026-08-30 22:55 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260830225138.A31EB1F000E9@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=lee@kernel.org \
--cc=linusw@kernel.org \
--cc=mfd@lists.linux.dev \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox