Re: [PATCH 2/7] arm64: dts: rockchip: Rename rk3288 HDMI audio card

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [High] Changing the ALSA sound card name breaks userspace ABI and backward compatibility.
- [Low] The commit subject uses the `arm64:` subsystem prefix, but modifies an ARM 32-bit device tree file.
--

commit 3a52d07446ba896b26f24f7276cf2ade84038b3b
Author: Detlev Casanova <detlev.casanova@collabora.com>

arm64: dts: rockchip: Rename rk3288 HDMI audio card

This commit renames the HDMI audio card in the rk3288-miqi device tree
from "HDMI" to "RK3288 HDMI" to avoid name collisions with other Rockchip
SoCs.

> arm64: dts: rockchip: Rename rk3288 HDMI audio card

[Severity: Low]
Does this commit subject use the correct architecture prefix?

The file being modified is `arch/arm/boot/dts/rockchip/rk3288-miqi.dts`, 
which belongs to the 32-bit ARM architecture, but the subject uses the 
arm64 prefix.

> diff --git a/arch/arm/boot/dts/rockchip/rk3288-miqi.dts b/arch/arm/boot/dts/rockchip/rk3288-miqi.dts
> index a5f5c6d38f801..090255244c86f 100644
> --- a/arch/arm/boot/dts/rockchip/rk3288-miqi.dts
> +++ b/arch/arm/boot/dts/rockchip/rk3288-miqi.dts
> @@ -82,7 +82,7 @@ vcc_sys: regulator-vsys {
>  	sound {
>  		compatible = "simple-audio-card";
>  		simple-audio-card,format = "i2s";
> -		simple-audio-card,name = "HDMI";
> +		simple-audio-card,name = "RK3288 HDMI";

[Severity: High]
Does this modification break userspace ABI and backward compatibility?

The simple-audio-card,name property defines the ALSA sound card name 
exposed to userspace. Audio servers like PulseAudio and PipeWire, as well 
as configuration tools like ALSA UCM and asound.state, rely on this name 
to identify the hardware, apply routing profiles, and restore volume levels.

Upgrading the kernel on an RK3288 MiQi board changes the ALSA card name 
from 'HDMI' to 'RK3288 HDMI'. Userspace configurations looking for the 
'HDMI' card (which has been present since commit 2a91dcd5be9d) will fail 
to match the new name, resulting in broken audio routing or lost volume 
states.

>  		simple-audio-card,mclk-fs = <512>;
>  
>  		simple-audio-card,codec {

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260831-fix-rockchip-hdmi-audio-names-v1-0-5b155ae05293@collabora.com?part=2