Re: [PATCH 7/7] arm64: dts: rockchip: Rename rk3588 HDMI audio cards

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Critical] Renaming the ALSA sound card breaks existing userspace configurations that rely on the old name.
--

commit ee162ed61bb57db0487beb65c4dfb703f1987e94
Author: Detlev Casanova <detlev.casanova@collabora.com>
arm64: dts: rockchip: Rename rk3588 HDMI audio cards

This commit renames the ALSA sound cards in the devicetree from "hdmi0" and
"hdmi1" to "RK3588 HDMI0" and "RK3588 HDMI1". The stated goal is to better
identify the SoC in user-visible ALSA fields and match other naming schemes
used across the Rockchip family.

> diff --git a/arch/arm64/boot/dts/rockchip/rk3588-base.dtsi b/arch/arm64/boot/dts/rockchip/rk3588-base.dtsi
> index 376ad04e07869..7892e18a7835a 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3588-base.dtsi
> +++ b/arch/arm64/boot/dts/rockchip/rk3588-base.dtsi
> @@ -376,7 +376,7 @@ hdmi0_sound: hdmi0-sound {
>  		compatible = "simple-audio-card";
>  		simple-audio-card,format = "i2s";
>  		simple-audio-card,mclk-fs = <128>;
> -		simple-audio-card,name = "hdmi0";
> +		simple-audio-card,name = "RK3588 HDMI0";

[Severity: Critical]
Does this change introduce a userspace regression? Changing the ALSA sound
card name alters the user-visible userspace ABI. Userspace audio daemons
such as PipeWire, PulseAudio, and ALSA Use Case Manager (UCM) profiles
often match against the exact card name (in this case, "hdmi0") to apply
specific routing and hardware configurations.

Will upgrading the kernel cause existing userspace configurations to fail
to identify the audio card, resulting in a loss of audio functionality?

> diff --git a/arch/arm64/boot/dts/rockchip/rk3588-extra.dtsi b/arch/arm64/boot/dts/rockchip/rk3588-extra.dtsi
> index b251bb129cdbf..2bcf30d8a338d 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3588-extra.dtsi
> +++ b/arch/arm64/boot/dts/rockchip/rk3588-extra.dtsi
> @@ -11,7 +11,7 @@ hdmi1_sound: hdmi1-sound {
>  		compatible = "simple-audio-card";
>  		simple-audio-card,format = "i2s";
>  		simple-audio-card,mclk-fs = <128>;
> -		simple-audio-card,name = "hdmi1";
> +		simple-audio-card,name = "RK3588 HDMI1";

[Severity: Critical]
Similarly for the hdmi1-sound node, does renaming this card break
compatibility for existing userspace environments relying on the original
"hdmi1" name? The kernel generally enforces a strict no-regressions
policy for userspace interfaces.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260831-fix-rockchip-hdmi-audio-names-v1-0-5b155ae05293@collabora.com?part=7